Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear saved query crashes kibana on Discover in some cases #63505

Closed
lizozom opened this issue Apr 14, 2020 · 3 comments
Closed

Clear saved query crashes kibana on Discover in some cases #63505

lizozom opened this issue Apr 14, 2020 · 3 comments
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0 v8.0.0

Comments

@lizozom
Copy link
Contributor

lizozom commented Apr 14, 2020

Kibana version:
master \ 7.7

Elasticsearch version:

Server OS version:

Browser version:

Browser OS version:

Original install method (e.g. download page, yum, from source, etc.):

Describe the bug:

Steps to reproduce:

  1. Setup a cloud deployment on staging
  2. Create a new user on that deployment
  3. Run Kibana locally, with ES running on that deployment
  4. Login using the user you just created and load sample data
  5. Create a saved query on discover
  6. Try clearing the saved query

Kibana gets completely stuck (gets into a weird rendering loop).
The only way to resurrect it is killing the chrome process.
As this does not happen in a setup where ES is running locally, this makes me suspect we have some new race condition.

Expected behavior:
In 7.6 this flow works

Screenshots (if relevant):

image

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

@lizozom lizozom added bug Fixes for quality problems that affect the customer experience v8.0.0 v7.7.0 labels Apr 14, 2020
@lizozom lizozom changed the title Clear saved query crashes kibana on Discover (weird setup) Clear saved query crashes kibana on Discover (cloud ES setup) Apr 14, 2020
@Dosant
Copy link
Contributor

Dosant commented Apr 15, 2020

This should fix the issue: #63554

From what I understood, it is not related to cloud ES setup. It is related to query language value in local storage.

Bug is reproduced reliably in any environment if preferred query language in uiSettings is different from saved query language in localStorage. :

To reproduce:

Assuming KQL is default language
Go to discover and save a query with KQL
Clear the query
Switch to lucene
Reload the page (lucene should be in the query bar)
Apply the saved query (the one with KQL)
Clear query
Browser is frozen

#63554

@Dosant Dosant changed the title Clear saved query crashes kibana on Discover (cloud ES setup) Clear saved query crashes kibana on Discover in some cases Apr 15, 2020
@rayafratkina rayafratkina added Feature:Discover Discover Application Team:AppArch Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0 v8.0.0
Projects
None yet
Development

No branches or pull requests

5 participants