Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Timelion deprecation warning to the migration assistant #63014

Closed
rayafratkina opened this issue Apr 8, 2020 · 7 comments · Fixed by #75541
Closed

Add Timelion deprecation warning to the migration assistant #63014

rayafratkina opened this issue Apr 8, 2020 · 7 comments · Fixed by #75541
Labels
Breaking Change Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.0.0

Comments

@rayafratkina
Copy link
Contributor

Describe the feature:
Per #63012 we are planning to remove Timelion app in 8.0
To make this migration easier, we would like to add a note in the migration assistant if it detects Timelion is enabled or sheets exists

@rayafratkina rayafratkina added the Team:Operations Team label for Operations Team label Apr 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley tylersmalley added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more and removed Team:Operations Team label for Operations Team labels Apr 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@stratoula
Copy link
Contributor

Right now the upgrade assistant has not been used to surface deprecations like these, only ES index-level deprecations. So we don't have the mechanism to add a deprecation notice on the upgrade assistant. cc @timroes @rayafratkina @timductive

So after syncing with Tim will close it.

@rayafratkina
Copy link
Contributor Author

@stratoula if user does not notice the deprecation before migration, their existing sheets will be gone, they will not show up as visualizations. Correct?

I understand the existing upgrade assistant infrastructure does not support this but have we talked to the operations team about how hard it would be to add?
cc @AlonaNadler

@cjcenizal
Copy link
Contributor

FYI, we have an issue open that describes adding the ability to surface Kibana plugin deprecations in Upgrade Assistant (#54702).

@stratoula
Copy link
Contributor

stratoula commented Aug 17, 2020

@rayafratkina I am re-discussing it with the Elasticsearch-ui team if we could add this to their roadmap and let you know. I will re-open it until we make a conclusion

@stratoula stratoula reopened this Aug 17, 2020
@stratoula
Copy link
Contributor

We decided here to procced with adding a server log, informing the user that the Timelion app is going to be removed on v8.0 when Timelion sheets are detected.

alexwizp added a commit to alexwizp/kibana that referenced this issue Aug 21, 2020
alexwizp added a commit that referenced this issue Aug 24, 2020
* Add Timelion deprecation warning to the migration assistant

Closes: #63014

* fix PR comments

* update message

* fix integration tests

Co-authored-by: Elastic Machine <[email protected]>
alexwizp added a commit to alexwizp/kibana that referenced this issue Aug 24, 2020
* Add Timelion deprecation warning to the migration assistant

Closes: elastic#63014

* fix PR comments

* update message

* fix integration tests

Co-authored-by: Elastic Machine <[email protected]>
alexwizp added a commit that referenced this issue Aug 24, 2020
* Add Timelion deprecation warning to the migration assistant

Closes: #63014

* fix PR comments

* update message

* fix integration tests

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants