Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnifiedDocViewer] Remove large string truncation #62920

Closed
lio-p opened this issue Apr 8, 2020 · 1 comment · Fixed by #164236
Closed

[UnifiedDocViewer] Remove large string truncation #62920

lio-p opened this issue Apr 8, 2020 · 1 comment · Fixed by #164236
Assignees
Labels
:DataDiscovery/fix-it-week Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. usability

Comments

@lio-p
Copy link

lio-p commented Apr 8, 2020

Kibana version: 7.6.1

Elasticsearch version: 7.6.1

Browser version: Chrome 80.0.3987.163

Browser OS version: macOS Mojave

Original install method (e.g. download page, yum, from source, etc.): Elasticsearch Service

Describe the bug:

In a Saved search (Discover or integrated in a Dashboard), long text, in the table view, does not get wrap as the window get resized past a certain minimum threshold.

This minimum threshold depends on the number of columns selected in the saved search. If there is a only a few columns selected, the screen can get resized to very small size before truncating the text which is fine. This behavior become an issue when there are many columns selected, above 10 column and/or the column name are long as they take more horizontal space. In this case, the horizontal resize is very limited as the text gets truncated early on.

Steps to reproduce:

  1. Create an index with sample documents that contains many attributes (long attribute name helps). At least one attribute that contains a large text.
  2. Create an index pattern that points to this index.
  3. In Discover, toggle many columns, expand the document and try to resize horizontally. Up to a point, the large text is being wrapped until it gets truncated.

Expected behavior:

I would expect the text in the expanded view to not be truncated.

Screenshots (if relevant):

image

@joelgriffith joelgriffith added bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes removed the bug Fixes for quality problems that affect the customer experience label Jul 14, 2021
@timroes timroes added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@kertal kertal added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort labels Dec 5, 2022
@kertal kertal changed the title Discover view truncate large text [UnifiedDocViewer] Remove large string truncation Aug 9, 2023
timductive added a commit that referenced this issue Aug 23, 2023
## Summary

Closes #62920


![image](https://github.com/elastic/kibana/assets/1280964/a1f07fe3-be6c-47c8-81e3-4ee8767ed426)



### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:DataDiscovery/fix-it-week Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. usability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants