Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Remove remaining INDEX_NAME constants #62255

Closed
andrewvc opened this issue Apr 2, 2020 · 1 comment · Fixed by #62256
Closed

[Uptime] Remove remaining INDEX_NAME constants #62255

andrewvc opened this issue Apr 2, 2020 · 1 comment · Fixed by #62256
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0

Comments

@andrewvc
Copy link
Contributor

andrewvc commented Apr 2, 2020

In #60869 all references to the heartbeat index pattern were replaced with references to the user defined values in a kibana saved object.

It looks like one endpoint + ML slipped through. We need to delete https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/uptime/common/constants/index_names.ts and fix any references to it to use the dynamicSettings object.

@andrewvc andrewvc added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0 labels Apr 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@andrewvc andrewvc self-assigned this Apr 2, 2020
@andrewvc andrewvc added the review label Apr 2, 2020
andrewvc added a commit to andrewvc/kibana that referenced this issue Apr 2, 2020
Fixes elastic#62255 . There were some remaining usages of a static defined
index name.
andrewvc added a commit that referenced this issue Apr 2, 2020
Fixes #62255 . There were some remaining usages of a static defined
index name.

Co-authored-by: Elastic Machine <[email protected]>
andrewvc added a commit to andrewvc/kibana that referenced this issue Apr 2, 2020
)

Fixes elastic#62255 . There were some remaining usages of a static defined
index name.

Co-authored-by: Elastic Machine <[email protected]>
andrewvc added a commit to andrewvc/kibana that referenced this issue Apr 2, 2020
)

Fixes elastic#62255 . There were some remaining usages of a static defined
index name.

Co-authored-by: Elastic Machine <[email protected]>
andrewvc added a commit that referenced this issue Apr 2, 2020
…62323)

Fixes #62255 . There were some remaining usages of a static defined
index name.

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
andrewvc added a commit that referenced this issue Apr 2, 2020
…62322)

Fixes #62255 . There were some remaining usages of a static defined
index name.

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants