-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[State Management] Inconsistent behavior with saved queries #59303
Comments
@timroes Do you know of any previous discussions about the behavior of saved queries that could be referenced here? |
I wouldn't know what to link to for this right now. Since filters and the saved queries are now maintained by app arch I'd ping @alexh97 here for awareness, and also @AlonaNadler since she might know about prior discussions around how the behavior should be. |
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Like @kertal had mentioned, the inconsistency is a result of the fact that discover uses I will work on fixing those issues when using |
Broke down this issue into individual tasks |
Kibana version: latest
Elasticsearch version: latest
Describe the bug:
The behavior in the legacy apps like
Discover
,Visualize
andDashboard
using thesavedQuery
doesn't look obvious.To understand, what is going on, you have two create couple of saved queries:
Create two different saved queries with at least one filter in each, e.x.:
General steps:
a) Create a new instance of
Visalization
/Dashboard
/Discover
b) Add any of created
savedQuery
to the search:c) Add additional filter to the search, e.x.:
There are several possible cases described below 👇
Reloading the page
Make all of the general steps. Reload the browser window.
Custom app filter will gone, the saved query filters take precedence over app filters.
Addressed in #59805
Changing the
savedQuery
id in theurl
Make all of the general steps.
Change the
savedQuery
id in theurl
, e.x.savedQuery:spalger
->savedQuery:member
, press enter.Saved query is changed, custom app filter will gone, the saved query filters take precedence over app filters.
Addressed in #59805
Save the
Visalization
/Dashboard
/Discover
Make all of the general steps. Save your created instance with the
Save
button.All of the filter will become
appFilters
, thesavedQuery
is not selected anymore.Opened separate issue #59808
Also, visualize and discover should switch to use
use-default-behaviors
for consistency.#59811
#59812
Proposal
My proposal is to the behave in one way.
The saved query filters should be
merged
with the app filters, but not be removed at all.The saved query will still take a precedence (means overlapping filters will go to saved query),
but the app filters will be not lost.
The text was updated successfully, but these errors were encountered: