Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Storybooks on CI #58024

Closed
streamich opened this issue Feb 19, 2020 · 4 comments · Fixed by #87701
Closed

Build Storybooks on CI #58024

streamich opened this issue Feb 19, 2020 · 4 comments · Fixed by #87701
Assignees
Labels
Feature:CI Continuous integration Feature:Storybook Team:Operations Team label for Operations Team

Comments

@streamich
Copy link
Contributor

streamich commented Feb 19, 2020

To make sure all Storybooks work, we need to build all of them on CI. A static version with --site flag. Like:

yarn storybook canvas --site
yarn storybook embeddable --site
yarn storybook apm --site
...

Along with the each plugins' Storybook we'll need to publish a composite Storybook, which does not include stories itself (except maybe a README) and includes definitions (which can be derived from the aliases) for the other published Storybooks.

We would like to have links to builds for stories in GitHub pull request comments. This does not need to be completed as part of this issue, but make sure such an issue exists before closing this one.

Depends on: #57628
Parent issue: #54707

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich mentioned this issue Feb 19, 2020
11 tasks
@tylersmalley tylersmalley added the Feature:CI Continuous integration label Feb 20, 2020
@tylersmalley
Copy link
Contributor

tylersmalley commented Oct 13, 2020

As an update here, this is tentatively planned for 7.12.

@brianseeders
Copy link
Contributor

brianseeders commented Jan 11, 2021

@streamich would you mind taking a look at what I have so far here (from a functionality standpoint)? #87701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:CI Continuous integration Feature:Storybook Team:Operations Team label for Operations Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants