-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📕 Storybook Roadmap #54707
Comments
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Pinging @elastic/kibana-operations (Team:Operations) |
Nice PR!
Just wanted to give you a heads up that Chromatic already has this built in along with visual review and visual regression testing so there's no need to build it separately if you decide to use Chromatic. |
Can I ask that one one more thing get added to this roadmap? storybook-addon-a11y runs the same library (axe) that we're using for automated accessibility testing. Exposing this info earlier in the dev cycle could help cut out the more time consuming test cycles. For more info, in the Real-time accessibility testing with Storybook blogpost they go over this addon some more. |
@myasonik I've added it. |
closing this as it seems the majority of items have been completed |
Below is a list of next steps to improve our Storybook setup after the initial PR is merged:
@kbn/ui-shared-deps
instead of building DLL manually in@kbn/storybook
. Storybook 6 and config changes #75357@kbn/storybook
, add guidelines/conventions. Storybook 6 and config changes #75357.scss
files.The text was updated successfully, but these errors were encountered: