-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up TSVB API interface, convert to typescript #57342
Labels
Feature:TSVB
TSVB (Time Series Visual Builder)
impact:low
Addressing this issue will have a low level of impact on the quality/strength of our product.
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
technical debt
Improvement of the software architecture and operational architecture
Comments
flash1293
added
Feature:TSVB
TSVB (Time Series Visual Builder)
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
labels
Feb 11, 2020
Pinging @elastic/kibana-app (Team:KibanaApp) |
DianaDerevyankina
added a commit
to DianaDerevyankina/kibana
that referenced
this issue
May 6, 2020
7 tasks
DianaDerevyankina
added a commit
that referenced
this issue
May 8, 2020
* Clean up TSVB turn Joi schema into kbn schema Part of #57342 * Return validationTelemerty and logging part back * Add schema.maybe() where it was missed
DianaDerevyankina
added a commit
to DianaDerevyankina/kibana
that referenced
this issue
May 8, 2020
* Clean up TSVB turn Joi schema into kbn schema Part of elastic#57342 * Return validationTelemerty and logging part back * Add schema.maybe() where it was missed
DianaDerevyankina
added a commit
that referenced
this issue
May 8, 2020
DianaDerevyankina
added a commit
to DianaDerevyankina/kibana
that referenced
this issue
Jun 8, 2020
7 tasks
DianaDerevyankina
added a commit
that referenced
this issue
Jun 25, 2020
* Clean up TSVB type client code to conform to the schema Part of #57342 * Replace FieldDescriptor with IFieldType, add UIRestrictions interface * Replace expect from chai with @kbn/expect, remove unnecessary type * Add TimeseriesUIRestrictions type and refactor add_delete_buttons.test * Replace some types with MetricsItemsSchema['values'] to avoid duplications Co-authored-by: Elastic Machine <[email protected]>
DianaDerevyankina
added a commit
to DianaDerevyankina/kibana
that referenced
this issue
Jun 25, 2020
* Clean up TSVB type client code to conform to the schema Part of elastic#57342 * Replace FieldDescriptor with IFieldType, add UIRestrictions interface * Replace expect from chai with @kbn/expect, remove unnecessary type * Add TimeseriesUIRestrictions type and refactor add_delete_buttons.test * Replace some types with MetricsItemsSchema['values'] to avoid duplications Co-authored-by: Elastic Machine <[email protected]>
DianaDerevyankina
added a commit
that referenced
this issue
Jun 26, 2020
) * Clean up TSVB type client code to conform to the schema Part of #57342 * Replace FieldDescriptor with IFieldType, add UIRestrictions interface * Replace expect from chai with @kbn/expect, remove unnecessary type * Add TimeseriesUIRestrictions type and refactor add_delete_buttons.test * Replace some types with MetricsItemsSchema['values'] to avoid duplications Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
9 tasks
2 tasks
4 tasks
stratoula
changed the title
Clean up TSVB API interface
Clean up TSVB API interface, convert to typescript
Jun 2, 2023
stratoula
added
the
impact:low
Addressing this issue will have a low level of impact on the quality/strength of our product.
label
Jun 2, 2023
stratoula
added
the
technical debt
Improvement of the software architecture and operational architecture
label
Jan 26, 2024
I am going to close this issue as we are in the phase of deprecating TSVB slowly so we don't intend to add more effort to tech dept tasks, unless this is super necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:TSVB
TSVB (Time Series Visual Builder)
impact:low
Addressing this issue will have a low level of impact on the quality/strength of our product.
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
technical debt
Improvement of the software architecture and operational architecture
The TSVB plugin is largely untyped. This is especially problematic because large config objects are sent from the client to the server without a defined shape. A preliminary Joi schema validating the config objects is currently in place in
src/plugins/vis_type_timeseries/server/routes/post_vis_schema.ts
, but might contain subtle mistakes, especially since saved objects can contain configurations created with old, potentially buggy versions of TSVB.Additionally the TSVB server side code still assumes the shape of the legacy platform request object in some places - this abstraction is leaking out into the search strategy extension point used by rollup.
To clean this up and get to a well-defined API interface (both for the route and extension point), multiple clean up steps are required:
@kbn/schema
- this will provide a type we can use elsewhereThe text was updated successfully, but these errors were encountered: