-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email action - user and password should be optional #57143
Comments
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
So I think we want to make the secrets properties optional, using the "nullable" schema function to have them saveable as a null: kibana/x-pack/plugins/actions/server/builtin_action_types/email.ts Lines 77 to 80 in cf9b64e
And then not set them in the transport object we send to nodemailer, if they are null: kibana/x-pack/plugins/actions/server/builtin_action_types/email.ts Lines 147 to 150 in cf9b64e
I wonder if we'll need some additional nodemailer options, for some reason. We'll see. |
resolves elastic#57143 Currently, the built-in email action requires user/password properties to be set in it's secrets parameters. This PR changes that requirement, so they are no longer required.
resolves #57143 Currently, the built-in email action requires user/password properties to be set in it's secrets parameters. This PR changes that requirement, so they are no longer required.
resolves elastic#57143 Currently, the built-in email action requires user/password properties to be set in it's secrets parameters. This PR changes that requirement, so they are no longer required.
Describe the feature:
The email action requires
user
andpassword
in its secrets schema, even though an SMTP service is not required to have authentication.Describe a specific use case for the feature:
Connecting to an internal SMTP service that does not use authentication. Currently this will give an
error like:
See also #50646
The text was updated successfully, but these errors were encountered: