Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouped Kibana nav #53313

Closed
1 of 5 tasks
myasonik opened this issue Dec 17, 2019 · 3 comments · Fixed by #53545
Closed
1 of 5 tasks

Grouped Kibana nav #53313

myasonik opened this issue Dec 17, 2019 · 3 comments · Fixed by #53545
Assignees
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@myasonik
Copy link
Contributor

myasonik commented Dec 17, 2019

Building on top of #29222 and elastic/dev#1329, it's time to get going on the grouped nav!

Grouping

  • [Recently viewed]
  • [Analyze]
    • Discover
    • Visualize
    • Dashboard
    • Canvas
    • Maps
    • Machine learning
    • Graph
    • Timelion
  • [Observability]
    • Logs
    • Metrics
    • APM
    • Uptime
  • [Security]
    • [SIEM]
  • [Management]
    • Stack management
    • Stack monitoring
    • Add data
    • Dev tools

Implementation details

  • Disable grouping for the whole nav when:
    • Using the open source license
    • There are less than 6 total available applications
  • Disable grouping for the group when there is only 1 sub-application
    • Show the group name (e.g., Security) and link directly to the single application (e.g., SIEM)
  • Advanced setting to turn off grouping

Prototype

grouped nav prototype

Blockers

Stretch goals

@myasonik myasonik self-assigned this Dec 17, 2019
@Bargs Bargs added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Dec 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Design)

@lizozom
Copy link
Contributor

lizozom commented Jan 22, 2020

This looks great @myasonik !
Some feedback -

  • ATM There is no indication to which items open another sub-menu and which don't. When exploring the menu, I thought clicking on items always opens a sub menu. But then I was surprised by siem navigating me to the new app (which takes some time!). I feel like having the submenu open automatically when staying on the button for more than a second (?) can help with this.

  • This would also decrease the number of clicks per navigation (ATM it became two for most apps). If sub menus open on hover, this would bring it back to 1.

  • Can custom plugins control their place in the side navigation and add themselves into a sub menu? Is there documentation for it?

@myasonik
Copy link
Contributor Author

@lizozom

Your first two items about nav UI and design we're largely just ok with. There'll be a learning curve for the new nav, but it should be a one time cost and should smooth out over time as people become comfortable with it. (We might rethink some of these over time if people continue to have issues but there's a larger 8.0 nav rework planned anyways so this likely isn't a forever phase for the UI.)

And I've added some docs but if you have suggestions on where to put more docs (or what other docs to add) I'd be happy to do it! You can see them all by filtering to .md files in the PR. The short of it is:

  • When setting up a nav link, plugins can define their own category if they want. category can take an order which is sorted on when building the nav.
  • Prior to my work, nav links already took an order property as well which is sorted on to set the actual link order which is still used, just within their category sub-navs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants