Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unused navigation code for localStorage #44389

Closed
ryankeairns opened this issue Aug 29, 2019 · 2 comments
Closed

Clean up unused navigation code for localStorage #44389

ryankeairns opened this issue Aug 29, 2019 · 2 comments
Labels
loe:small Small Level of Effort REASSIGN from Team:Core UI Deprecated label for old Core UI team

Comments

@ryankeairns
Copy link
Contributor

TL;DR - I believe some (all?) of the code in this commit is unused and can be removed: b1305c6

When the new nav drawer was introduced in Kibana 7.0, code was put into place in the event we wanted to handle locking the nav drawer open in the future. The future has arrived and the nav drawer can now be locked open, but new code was written to handle localStoarge of the locked state (#43916 (comment)) thus making the aforementioned commit likely obsolete.

@ryankeairns ryankeairns added the REASSIGN from Team:Core UI Deprecated label for old Core UI team label Aug 29, 2019
@thompsongl
Copy link
Contributor

thompsongl commented Aug 29, 2019

Yes, I didn't realize that any of that code (b1305c6) was relevant when I implemented the new lockable nav. So if it has no purpose beyond nav locking, all that code is obsolete now.

@myasonik myasonik mentioned this issue Dec 17, 2019
5 tasks
@ryankeairns ryankeairns added the loe:small Small Level of Effort label Jan 29, 2020
@ryankeairns
Copy link
Contributor Author

Removed by commit 4deea08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
loe:small Small Level of Effort REASSIGN from Team:Core UI Deprecated label for old Core UI team
Projects
None yet
Development

No branches or pull requests

2 participants