Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metric UI] Convert layout JSON to React components for Inventory models #48808

Closed
simianhacker opened this issue Oct 21, 2019 · 1 comment · Fixed by #49134
Closed

[Metric UI] Convert layout JSON to React components for Inventory models #48808

simianhacker opened this issue Oct 21, 2019 · 1 comment · Fixed by #49134
Labels
enhancement New value added to drive a business result Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@simianhacker
Copy link
Member

Currently the layout for the metric detail page is expressed in JSON. We feel that it would make more sense and allow for greater flexibility if instead of returning a JSON object that we then interpret into React, to just return a React component to generate the pages. This will also give us more flexibility for each layout.
@simianhacker simianhacker added enhancement New value added to drive a business result Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Oct 21, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@simianhacker simianhacker mentioned this issue Oct 21, 2019
Merged
@simianhacker simianhacker changed the title [Metric UI] Convert layout JSON to react components for Inventory models [Metric UI] Convert layout JSON to React components for Inventory models Oct 21, 2019
simianhacker added a commit to simianhacker/kibana that referenced this issue Oct 28, 2019
@simianhacker
Convert layouts to use React compontents
64c250f 
- This PR closes elastic#48808
- Move all files under pages/metrics
@simianhacker simianhacker mentioned this issue Oct 28, 2019
Merged
simianhacker added a commit that referenced this issue Nov 13, 2019
@simianhacker
[Metrics UI] Convert layouts to use React components (#49134)
1010f28 
* Convert layouts to use React compontents

- This PR closes #48808
- Move all files under pages/metrics

* Renaming layout files; Fixing some types; Removing unused types

* Fixing naming issue

* Fixing path

* Fixing i18n stuff

* [Metrics UI] Move toolbars under inventory models

* Fixing imports; wrapping code in useMemo to optimize

* removing unused imports

* Removing prototype page
@zube zube bot added [zube]: Done and removed [zube]: Ready labels Nov 13, 2019
simianhacker added a commit to simianhacker/kibana that referenced this issue Nov 18, 2019
@simianhacker
[Metrics UI] Convert layouts to use React components (elastic#49134)
64c56d0 
* Convert layouts to use React compontents

- This PR closes elastic#48808
- Move all files under pages/metrics

* Renaming layout files; Fixing some types; Removing unused types

* Fixing naming issue

* Fixing path

* Fixing i18n stuff

* [Metrics UI] Move toolbars under inventory models

* Fixing imports; wrapping code in useMemo to optimize

* removing unused imports

* Removing prototype page
simianhacker added a commit that referenced this issue Nov 18, 2019
@simianhacker
[Metrics UI] Convert layouts to use React components (#49134) (#50982)
c2a3991 
* Convert layouts to use React compontents

- This PR closes #48808
- Move all files under pages/metrics

* Renaming layout files; Fixing some types; Removing unused types

* Fixing naming issue

* Fixing path

* Fixing i18n stuff

* [Metrics UI] Move toolbars under inventory models

* Fixing imports; wrapping code in useMemo to optimize

* removing unused imports

* Removing prototype page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Metrics UI] Convert layouts to use React components simianhacker/kibana
3 participants
@simianhacker @sgrodzicki @elasticmachine