Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Align http colors on requests per minute graph with trace summary #47817

Closed
sorenlouv opened this issue Oct 10, 2019 · 1 comment · Fixed by #47915
Closed

[APM] Align http colors on requests per minute graph with trace summary #47817

sorenlouv opened this issue Oct 10, 2019 · 1 comment · Fixed by #47915
Assignees
@smith
Labels
enhancement New value added to drive a business result good first issue low hanging fruit Team:APM All issues that need APM UI Team support

Comments

@sorenlouv
Copy link
Member

In #47114 the colors for http status codes were changed for the trace summary.
The colors on the Requests per minute graph should be aligned.

image.png
@sorenlouv sorenlouv added [zube]: (7.5) Planned for release enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support labels Oct 10, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@smith smith self-assigned this Oct 10, 2019
@smith smith mentioned this issue Oct 10, 2019
Merged
smith added a commit to smith/kibana that referenced this issue Oct 14, 2019
@smith
[APM] Use same colors for HTTP status everywhere
2d92e25 
Use the same colors on the RPM/TPM graphs as in the status code badge.

Fixes elastic#47817.
smith added a commit that referenced this issue Oct 15, 2019
@smith
[APM] Use same colors for HTTP status everywhere (#47915)
d8f0ed5 
* [APM] Use same colors for HTTP status everywhere

Use the same colors on the RPM/TPM graphs as in the status code badge.

Fixes #47817.

* don't export that const

* Change colors

* Remove unused import
smith added a commit to smith/kibana that referenced this issue Oct 15, 2019
@smith
[APM] Use same colors for HTTP status everywhere (elastic#47915)
21009bf 
* [APM] Use same colors for HTTP status everywhere

Use the same colors on the RPM/TPM graphs as in the status code badge.

Fixes elastic#47817.

* don't export that const

* Change colors

* Remove unused import
smith added a commit that referenced this issue Oct 15, 2019
@smith
[7.x] [APM] Use same colors for HTTP status everywhere (#47915) (#48189)
3e2eff8 
* [APM] Use same colors for HTTP status everywhere

Use the same colors on the RPM/TPM graphs as in the status code badge.

Fixes #47817.

* don't export that const

* Change colors

* Remove unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smith smith

Labels
enhancement New value added to drive a business result good first issue low hanging fruit Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Use same colors for HTTP status everywhere smith/kibana
4 participants
@smith @sorenlouv @cjcenizal @elasticmachine