Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI][a11y] Should announce logs column reorder control #45300

Closed
simianhacker opened this issue Sep 10, 2019 · 8 comments
Closed

[Logs UI][a11y] Should announce logs column reorder control #45300

simianhacker opened this issue Sep 10, 2019 · 8 comments
Assignees
Labels
blocked Feature:Logs UI Logs UI feature Project:Accessibility Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@simianhacker
Copy link
Member

Steps to reproduce

1.Open Logs UI with screen reader (like Chrome Vox)
2. Tab until you get to the reorder icons in the logs columns section
3. Notice it doesn't announce anything.

image

Actual Result

  • Doesn't announce icon but does tab to it.

Expected Result

  • Should announce icon.

Kibana Version:

7.4.0-BC3

Screen reader: [if relevant]

Chrome Vox

@simianhacker simianhacker added Project:Accessibility Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Sep 10, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-logs-ui

@Zacqary
Copy link
Contributor

Zacqary commented Oct 14, 2019

VoiceOver announces this:

Screen Shot 2019-10-14 at 3 42 51 PM

It is ambiguous, though. Will investigate and see if we can update this, and see why Chrome Vox isn't working

@Zacqary
Copy link
Contributor

Zacqary commented Oct 14, 2019

aria-roledescription doesn't seem to be supported by Chrome Vox.

@Zacqary
Copy link
Contributor

Zacqary commented Oct 14, 2019

@simianhacker Was this using Chrome Vox Classic for Mac/Windows or using the latest Chrome Vox on a Chromebook? I'd want to submit a bug report to Chrome about this but only if it's occurring on Chrome OS, which is the only platform they're still supporting with it.

@Zacqary
Copy link
Contributor

Zacqary commented Oct 14, 2019

The underlying issue is with EuiDraggable which implements https://github.com/atlassian/react-beautiful-dnd, so we may need to do some digging to get this fixed

@Zacqary
Copy link
Contributor

Zacqary commented Oct 14, 2019

atlassian/react-beautiful-dnd#1389

Looks like react-beautiful-dnd has this on their radar, doesn't look like it's fixed yet

EDIT: It has indeed been fixed as of July, need to just update to the new version

@Zacqary
Copy link
Contributor

Zacqary commented Oct 14, 2019

Tracking in EUI here: elastic/eui#2427

@jasonrhodes
Copy link
Member

I think we'll get this improvement for free once EUI upgrades, so I don't think it's necessary to keep this open on our end anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Feature:Logs UI Logs UI feature Project:Accessibility Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

5 participants