Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFD: lift announcements #1389

Closed
alexreardon opened this issue Jul 4, 2019 · 1 comment
Closed

RFD: lift announcements #1389

alexreardon opened this issue Jul 4, 2019 · 1 comment

Comments

@alexreardon
Copy link
Collaborator

alexreardon commented Jul 4, 2019

We are moving away from aria-roledescription for our lift announcements #1238 #1385 . We are moving to aria-labelledby={ElementId} and pointing it to a visually hidden div. This yields a more consistent screen reader experience and scores better for accessibility tooling

liftInstruction will need to be static text that we just dump into a div

Options:

  • liftInstruction prop on DragDropContext and all drag handles share the same lift instruction. This way we only need to created one visually hidden div (already implemented in our virtual branch)
  • liftInstruction prop on drag handle and each drag handle gets it's very own visually hidden div. This allows for customisation between handles, but is pretty heavy.
  • go for liftInstruction on the DragDropContext and consumers can override aria-labelledby on a specific drag handle if they want it to be different from the others
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant