Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering on a search cell first inclusive then exclusive gives bad results #39802

Closed
stacey-gammon opened this issue Jun 27, 2019 · 7 comments
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience regression v7.4.0 v8.0.0

Comments

@stacey-gammon
Copy link
Contributor

Kibana version:
master

Steps to reproduce:

  • Add a saved search to a dashboard.
  • Click on the + maginfying glass in a cell
  • click on a the - magnifying glass in the cell

Expected results: either the filter changes, or a new filter is added that is negative and changes out everything. Instead, the data showing changes but the filter does not.

Screen Shot 2019-06-27 at 11 23 18 AM

@stacey-gammon stacey-gammon added bug Fixes for quality problems that affect the customer experience Team:AppArch labels Jun 27, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@lizozom
Copy link
Contributor

lizozom commented Jul 23, 2019

Same behavior occurs in Discover app as well

  1. Go to Discover
  2. Filter with +
  3. Filter with -

Result: The 3rd step has no effect.

@bhavyarm
Copy link
Contributor

I reproduced this on 7.2.1

@lizozom
Copy link
Contributor

lizozom commented Jul 23, 2019

@bhavyarm

Could you check (along with #41762) if these issues are reproduced prior to 7.2.1?

The code in 7.2.1 is significantly different and if we want to fix this in 7.2.1 (and before?) we need to develop a separate fix.
Do we? @ppisljar

@LeeDr
Copy link

LeeDr commented Jul 23, 2019

7.1.1 I did not reproduce the problem

@LeeDr
Copy link

LeeDr commented Jul 23, 2019

On 7.2.0 the results update but the filter doesn't.
On Discover;

  1. + filter on sample ecommerce data currency EUR
  2. - filter on EUR - the results update but the filter still shows the + filter.
    If you click on the filter it updates to show it's the NOT filter

@LeeDr LeeDr added regression and removed v7.3.0 labels Jul 23, 2019
@LeeDr
Copy link

LeeDr commented Jul 23, 2019

Since this isn't clearly a new regression from the previous release (there were problems in the previous releases on filters) we're not marking this a blocker for 7.3.0 or 7.2.1 release.

lizozom pushed a commit to lizozom/kibana that referenced this issue Jul 24, 2019
…esults - elastic#39802 (elastic#41754)

* Resolves elastic#39802

* Fixed tests that didn't detect the bug

* Don't expose filter manager's filters, but a copy.

* getPartitionedFilters to use getFilters (for clone)

* Adjust filter gen tests to invert filters now calling addFilters

* remove invertFilter method
lizozom pushed a commit to lizozom/kibana that referenced this issue Jul 24, 2019
…esults - elastic#39802 (elastic#41754)

* Resolves elastic#39802

* Fixed tests that didn't detect the bug

* Don't expose filter manager's filters, but a copy.

* getPartitionedFilters to use getFilters (for clone)

* Adjust filter gen tests to invert filters now calling addFilters

* remove invertFilter method
lizozom pushed a commit that referenced this issue Jul 24, 2019
…esults - #39802 (#41754) (#41857)

* Resolves #39802

* Fixed tests that didn't detect the bug

* Don't expose filter manager's filters, but a copy.

* getPartitionedFilters to use getFilters (for clone)

* Adjust filter gen tests to invert filters now calling addFilters

* remove invertFilter method
lizozom pushed a commit that referenced this issue Jul 24, 2019
…esults - #39802 (#41754) (#41859)

* Resolves #39802

* Fixed tests that didn't detect the bug

* Don't expose filter manager's filters, but a copy.

* getPartitionedFilters to use getFilters (for clone)

* Adjust filter gen tests to invert filters now calling addFilters

* remove invertFilter method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience regression v7.4.0 v8.0.0
Projects
None yet
Development

No branches or pull requests

5 participants