Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid prop type error in Stack Monitoring EuiInMemoryTable #39739

Open
igoristic opened this issue Jun 26, 2019 · 4 comments
Open

Invalid prop type error in Stack Monitoring EuiInMemoryTable #39739

igoristic opened this issue Jun 26, 2019 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Team:Monitoring Stack Monitoring team v8.0.0

Comments

@igoristic
Copy link
Contributor

Looks like EuiInMemoryTable is strict now and requires: field property for all the columns. So far I found this error on these pages:

  • Stack Monitoring > Logstash Nodes
  • Stack Monitoring > Elasticsearch Overview

Might also be in other places where ever we use EuiInMemoryTable.

**Please note that simply adding field: 'reloads.successes (to fix Logstash Nodes for example) will give a different error that reloads is undefined. There is no safeguard so the data object has to exist
@igoristic igoristic added bug Fixes for quality problems that affect the customer experience Team:Monitoring Stack Monitoring team v8.0.0 labels Jun 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring

@chrisronline
Copy link
Contributor

I'm actually not seeing this locally, and I don't see how it would happen looking at EUI code.

ComputedColumnType usage

ComputedColumnType definition

Is this on a specific version of EUI or something?

@igoristic
Copy link
Contributor Author

@chrisronline

I'm actually not seeing this locally, and I don't see how it would happen looking at EUI code.

Make sure you have the latest master and run yarn kbn bootstrap. This might have been introduced by elastic/eui#2044, still investigating

@chrisronline
Copy link
Contributor

Ah, yes I'm seeing this now too, nice catch!

cc @elastic/kibana-design

@igoristic igoristic mentioned this issue Dec 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Team:Monitoring Stack Monitoring team v8.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chrisronline @elasticmachine @igoristic