Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Move APM index pattern creation from Kibana startup #37499

Closed
sorenlouv opened this issue May 30, 2019 · 2 comments · Fixed by #37965
Closed

[APM] Move APM index pattern creation from Kibana startup #37499

sorenlouv opened this issue May 30, 2019 · 2 comments · Fixed by #37965
Assignees
@ogupte
Labels
blocker Team:APM All issues that need APM UI Team support v7.2.0

Comments

@sorenlouv
Copy link
Member

sorenlouv commented May 30, 2019 •
edited by ogupte
Loading

This issue proposes a quick fix for #35898 while waiting for a proper solution like #37498

Currently the APM index pattern is created when Kibana starts up:

kibana/x-pack/plugins/apm/server/new-platform/plugin.ts

Line 27 in e2ae24d

ensureIndexPatternExists(core);

This causes the Kibana Home Welcome screen to not show up, since it is only displayed if no index patterns exist:
https://github.com/elastic/kibana/blob/master/src/legacy/core_plugins/kibana/public/home/components/home.js#L89

To ensure that the very first user is able to see the welcome screen we should move the APM index pattern creation to the APM UI where we already fetch the index pattern:
https://github.com/sqren/kibana/blob/9ebba02e5c36db72faf5f3ee10308b588442eb43/x-pack/plugins/apm/public/services/rest/savedObjects.ts#L23-L41
@sorenlouv sorenlouv added Team:APM All issues that need APM UI Team support v7.2.0 labels May 30, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@sorenlouv
Copy link
Member Author

@ogupte Perhaps this would make sense for you to look at since you implemented the automatic index pattern creation?

@ogupte ogupte self-assigned this Jun 3, 2019
@ogupte ogupte mentioned this issue Jun 4, 2019
Merged
ogupte added a commit to ogupte/kibana that referenced this issue Jun 5, 2019
@ogupte
[APM] Closes elastic#37499 by moving the APM index creation from serv…
7a255ac 
…er startup

to savedObject request for the index pattern. It first checks if the
index pattern is saved, if not it creates it.
ogupte added a commit to ogupte/kibana that referenced this issue Jun 6, 2019
@ogupte
[APM] Moves the APM index creation from server startup (elastic#37965)
6cdfca6 
* [APM] Closes elastic#37499 by moving the APM index creation from server startup
to savedObject request for the index pattern. It first checks if the
index pattern is saved, if not it creates it.

* [APM] provide more meaninful status codes in the default error handler
ogupte added a commit that referenced this issue Jun 6, 2019
@ogupte
[APM] Moves the APM index creation from server startup (#37965)
d43ee7f 
* [APM] Closes #37499 by moving the APM index creation from server startup
to savedObject request for the index pattern. It first checks if the
index pattern is saved, if not it creates it.

* [APM] provide more meaninful status codes in the default error handler
ogupte added a commit to ogupte/kibana that referenced this issue Jun 6, 2019
@ogupte
[APM] Moves the APM index creation from server startup (elastic#37965)
d118093 
* [APM] Closes elastic#37499 by moving the APM index creation from server startup
to savedObject request for the index pattern. It first checks if the
index pattern is saved, if not it creates it.

* [APM] provide more meaninful status codes in the default error handler
ogupte added a commit that referenced this issue Jun 6, 2019
@ogupte
[APM] Moves the APM index creation from server startup (#37965) (#38233)
cd03248 
* [APM] Closes #37499 by moving the APM index creation from server startup
to savedObject request for the index pattern. It first checks if the
index pattern is saved, if not it creates it.

* [APM] provide more meaninful status codes in the default error handler
ogupte added a commit that referenced this issue Jun 6, 2019
@ogupte
[APM] Moves the APM index creation from server startup (#37965) (#38235)
35afc0d 
* [APM] Closes #37499 by moving the APM index creation from server startup
to savedObject request for the index pattern. It first checks if the
index pattern is saved, if not it creates it.

* [APM] provide more meaninful status codes in the default error handler
@sorenlouv sorenlouv mentioned this issue Nov 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ogupte ogupte

Labels
blocker Team:APM All issues that need APM UI Team support v7.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Moves the APM index creation from server startup ogupte/kibana
4 participants
@graphaelli @sorenlouv @ogupte @elasticmachine