Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Pings over time" chart missing description #35352

Closed
barlowm opened this issue Apr 19, 2019 · 2 comments · Fixed by #46689
Closed

"Pings over time" chart missing description #35352

barlowm opened this issue Apr 19, 2019 · 2 comments · Fixed by #46689
Assignees
Labels
Project:Accessibility Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability WCAG A

Comments

@barlowm
Copy link
Collaborator

barlowm commented Apr 19, 2019

Steps to reproduce (assumes ChromeVox or similar)

  1. Open Kibana/Uptime page
  2. Navigate by keyboard to the "Status over time" chart

StatusOverTimeChart

Actual Result
"Status over time heading 5"

There is no description for the chart itself. There is also no description of the chart data.

Expected Result

"Chart showing Status over time for 04/17/2019 from 11:41 to 11:56" (or whatever the appropriate values are)

This can be achieved by adding aria-label to container div for the chart:

<div class="euiSeriesChartContainer" 
aria-label="chart showing uptime status over time for 2019-04-17 from 11:41 to 11:56">

Navigating into the chart Chromevox reads just the times across the X-axis as you navigate over each one:

11:41 11:42 11:43, etc.

Chromevox should read the time and value for each chart item:

  • 2019-04-17 11:41 to 11:42 Up:3 Down:2
  • 2019-04-17 11:42 to 11:43 Up:3 Down:2

etc

This can be done by adding an "aria-label" inside each rect tag:

<rect 
    aria-label="2019-04-17 11:41 to 11:42 Up:3 Down:2" 
    x="0" 
    width="57.80603174603172" 
    y="28" 
    height="42" 
    style="opacity: 1; stroke: rgb(49, 133, 252); fill: rgb(49, 133, 252);">
</rect>

There is an article available on Making charts accessible for people with visual impairments, which also includes a discussion on how Highcharts approached making their chart products accessible.

Meta Issue
Accessibility Audit for Kibana 7.0
Make Uptime App Accessible for 7.0

Make Graph Accessible for 7.0
Make charts screen-reader-accessible

Kibana Version:
7.0

Relevant WCAG Criteria: WCAG Criterion
Guideline 1.1 Text Alternatives

@rayafratkina rayafratkina added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Apr 19, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime

@shahzad31 shahzad31 self-assigned this Sep 16, 2019
@shahzad31 shahzad31 changed the title "Status over time" chart missing description "Pings over time" chart missing description Sep 16, 2019
@andrewvc
Copy link
Contributor

We should add a description of the chart, but the individual rect tags will need to be done as a patch to EUI charts.

andrewvc pushed a commit that referenced this issue Oct 1, 2019
Fixes #35352

To Improve accessibility added aria-label to chart container to make it readable.
@zube zube bot reopened this Oct 1, 2019
@zube zube bot closed this as completed Oct 1, 2019
shahzad31 added a commit to shahzad31/kibana that referenced this issue Oct 2, 2019
…ic#46689)

Fixes elastic#35352

To Improve accessibility added aria-label to chart container to make it readable.
shahzad31 added a commit that referenced this issue Oct 2, 2019
… (#47092)

Fixes #35352

To Improve accessibility added aria-label to chart container to make it readable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project:Accessibility Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability WCAG A
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants