-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Angular based pages no longer use $q as the default Promise #28189
Comments
jgowdyelastic
added
bug
Fixes for quality problems that affect the customer experience
:ml
labels
Jan 7, 2019
Pinging @elastic/ml-ui |
2 tasks
1 task
1 task
walterra
added a commit
to walterra/kibana
that referenced
this issue
Jan 9, 2019
…wer (elastic#28237) Part of elastic#28189. Removes custom Promise code and fixes missing $applyAsync()s in AnomalyExplorer and Time Series Viewer.
walterra
added a commit
to walterra/kibana
that referenced
this issue
Jan 9, 2019
…wer (elastic#28237) Part of elastic#28189. Removes custom Promise code and fixes missing $applyAsync()s in AnomalyExplorer and Time Series Viewer.
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kibana version: 6.6+
Elasticsearch version: 6.6+
Server OS version: N/A
Browser version: All
Browser OS version: All
Original install method (e.g. download page, yum, from source, etc.): N/A
Describe the bug:
For every angular based page in ML, we replace
window.Promise
with$q
, this allows us to sharePromise
based util functions between angular and react code without needing to explicitly call$applyAsync
when a resolving promise has to update the page.This happens in a resolver, added to the routing stage of each page, and so happens before the page has fully loaded.
A recent change in core kibana undoes this change, reverting
Promise
back to a non-angular version after these resolvers have been run.#25711
This causes angular based pages to not update correctly when actions are performed or data has been loaded via a
Promise
Steps to reproduce:
Expected behavior:
Page should work as expected
**Screenshots (if relevant):**N/A
**Errors in browser console (if relevant):**N/A
**Provide logs and/or server output (if relevant):**N/A
**Any additional context:**N/A
PRs
initPromise
function [ML] Removing promise override function #28360The text was updated successfully, but these errors were encountered: