Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Angular based pages no longer use $q as the default Promise #28189

Closed
4 tasks done
jgowdyelastic opened this issue Jan 7, 2019 · 1 comment
Closed
4 tasks done
Labels
blocker bug Fixes for quality problems that affect the customer experience :ml v6.6.0

Comments

@jgowdyelastic
Copy link
Member

jgowdyelastic commented Jan 7, 2019

Kibana version: 6.6+

Elasticsearch version: 6.6+

Server OS version: N/A

Browser version: All

Browser OS version: All

Original install method (e.g. download page, yum, from source, etc.): N/A

Describe the bug:
For every angular based page in ML, we replace window.Promise with $q, this allows us to share Promise based util functions between angular and react code without needing to explicitly call $applyAsync when a resolving promise has to update the page.
This happens in a resolver, added to the routing stage of each page, and so happens before the page has fully loaded.

A recent change in core kibana undoes this change, reverting Promise back to a non-angular version after these resolvers have been run.
#25711

This causes angular based pages to not update correctly when actions are performed or data has been loaded via a Promise

Steps to reproduce:

  1. Open the Single Metric Job creation page
  2. Refresh the page (F5/cmd-R)
  3. Attempt to create a new job. The chart loading spinner doesn't disappear.

Expected behavior:
Page should work as expected

**Screenshots (if relevant):**N/A

**Errors in browser console (if relevant):**N/A

**Provide logs and/or server output (if relevant):**N/A

**Any additional context:**N/A

PRs

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience :ml labels Jan 7, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

walterra added a commit that referenced this issue Jan 9, 2019
…wer (#28237)

Part of #28189. Removes custom Promise code and fixes missing $applyAsync()s in AnomalyExplorer and Time Series Viewer.
walterra added a commit to walterra/kibana that referenced this issue Jan 9, 2019
…wer (elastic#28237)

Part of elastic#28189. Removes custom Promise code and fixes missing $applyAsync()s in AnomalyExplorer and Time Series Viewer.
walterra added a commit to walterra/kibana that referenced this issue Jan 9, 2019
…wer (elastic#28237)

Part of elastic#28189. Removes custom Promise code and fixes missing $applyAsync()s in AnomalyExplorer and Time Series Viewer.
walterra added a commit that referenced this issue Jan 9, 2019
…wer (#28237) (#28338)

Part of #28189. Removes custom Promise code and fixes missing $applyAsync()s in AnomalyExplorer and Time Series Viewer.
walterra added a commit that referenced this issue Jan 9, 2019
…wer (#28237) (#28339)

Part of #28189. Removes custom Promise code and fixes missing $applyAsync()s in AnomalyExplorer and Time Series Viewer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience :ml v6.6.0
Projects
None yet
Development

No branches or pull requests

3 participants