Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create arg type for formatnumber #23111

Closed
5 tasks
kibanamachine opened this issue Jul 13, 2018 · 4 comments · Fixed by #43059
Closed
5 tasks

Create arg type for formatnumber #23111

kibanamachine opened this issue Jul 13, 2018 · 4 comments · Fixed by #43059
Assignees
@cqliu1
Labels
enhancement New value added to drive a business result impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.4.0

Comments

@kibanamachine
Copy link
Contributor

Original comment by @cqliu1:

We should create a UI to build a Numeral.js number format for common formats. We may want to create a different form for each type of format. We'll also want to support units of measurement for currency and numbers.

Common formats:

  • Numbers
  • Currency
  • Percentages
  • Bytes
  • Duration

See LINK REDACTED
@kibanamachine
Copy link
Contributor Author

Original comment by @alexfrancoeur:

TSVB's implementation uses the same fork of numeraljs Kibana has for field formatters

screen shot 2018-07-13 at 2 54 19 pm

screen shot 2018-07-13 at 2 54 25 pm

Not that we need to copy, just providing some context. I really like the currency option you listed above. I do like the fact that the UI allows you to introduce a custom format.

@kibanamachine
Copy link
Contributor Author

Original comment by @cqliu1:

Related to LINK REDACTED.

@kibanamachine
Copy link
Contributor Author

Original comment by @alexfrancoeur:

Just bumping this one again for the metric viz since we don't have +1's from GitHub yet 😄

Edit: Well, I guess any element really. Not necessarily just the metric

@kibanamachine
Copy link
Contributor Author

Original comment by @cqliu1:

This may also be related to LINK REDACTED.

@kibanamachine kibanamachine added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort labels Sep 14, 2018
@alexfrancoeur alexfrancoeur mentioned this issue Sep 18, 2018
Merged
@alexfrancoeur alexfrancoeur mentioned this issue Dec 4, 2018
Closed
@ryankeairns ryankeairns mentioned this issue Jan 23, 2019
Closed
44 tasks
@cqliu1 cqliu1 mentioned this issue May 29, 2019
Closed
17 tasks
@timductive timductive added enhancement New value added to drive a business result impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jun 10, 2019
@cqliu1 cqliu1 self-assigned this Jul 12, 2019
@cqliu1 cqliu1 mentioned this issue Jul 25, 2019
Merged
6 tasks
@cqliu1 cqliu1 mentioned this issue Aug 9, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cqliu1 cqliu1

Labels
enhancement New value added to drive a business result impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Canvas] Added formatnumber and formatdate UIs to sidebar cqliu1/kibana
3 participants
@timductive @cqliu1 @kibanamachine