Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import saved objects dialog needs to be smaller #21570

Closed
bhavyarm opened this issue Aug 1, 2018 · 5 comments
Closed

Import saved objects dialog needs to be smaller #21570

bhavyarm opened this issue Aug 1, 2018 · 5 comments
Labels
cosmetic enhancement New value added to drive a business result Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Saved Objects stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Aug 1, 2018

Kibana version: 6.4.0 BC1

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: The dialog box for importing saved objects is really big and taking up a lot of space. This isn't really necessary.

screen shot 2018-08-01 at 4 11 09 pm
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience :Management labels Aug 1, 2018
@bhavyarm
Copy link
Contributor Author

bhavyarm commented Aug 1, 2018

cc @cjcenizal

@scottis
Copy link
Contributor

scottis commented Aug 15, 2018

@bhavyarm @bmcconaghy Is this better?

after

@cjcenizal
Copy link
Contributor

@scottis That looks better, we just need to make sure to use the maxWidth property added in elastic/eui#1090.

@scottis
Copy link
Contributor

scottis commented Aug 15, 2018 •
edited
Loading

@cjcenizal Yes, I am using euiFlyout--small in that screenshot, which has maxWidth defined on the resulting style.

max-width

I misread that. It looks like maxWidth isn't present in the current version of eui.

Looks like it works!

max-width

scottis added a commit to scottis/kibana that referenced this issue Aug 16, 2018
@scottis
Fixes elastic#21570
c4639c7
@timroes timroes added enhancement New value added to drive a business result cosmetic Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Saved Objects Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed :Management DO NOT USE bug Fixes for quality problems that affect the customer experience labels Nov 27, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@timroes timroes removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 30, 2018
@joshdover joshdover added the stale Used to mark issues that were closed for being stale label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cosmetic enhancement New value added to drive a business result Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Saved Objects stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@timroes @cjcenizal @joshdover @bmcconaghy @bhavyarm @scottis @elasticmachine