Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new-platform] migrate fatal error page to new platform #20695

Closed
spalger opened this issue Jul 11, 2018 · 0 comments
Closed

[new-platform] migrate fatal error page to new platform #20695

spalger opened this issue Jul 11, 2018 · 0 comments
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@spalger
Copy link
Contributor

spalger commented Jul 11, 2018

Once #20694 is complete we will start moving parts of the legacy platform over to the new platform, starting with the fatal error page. This page shows up when an error bubbles up to a place that we don't know how to recover from, tears down the page, and replaces it with a full-screen error message. Before any other parts of the legacy platform are brought over we should take care of this component.
@spalger spalger added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Jul 11, 2018
@spalger spalger mentioned this issue Jul 11, 2018
Closed
@kimjoar kimjoar mentioned this issue Jul 11, 2018
Closed
8 tasks
This was referenced Jul 11, 2018
Closed
Merged
spalger pushed a commit that referenced this issue Jul 30, 2018
Migrate ui/notify/fatal_error to new platform (#20752)
1532c5e 
Fixes #20695

Extracts the "fatal error" handling logic from the `ui/notify` module and reimplements it in the new platform, using EUI for the fatal error page and continuing to support the `fatalError()` and `addFatalErrorCallback()` methods exported by the `ui/notify` module.

![image](https://user-images.githubusercontent.com/1329312/43032175-d37fbafc-8c65-11e8-8f1f-da71f0dac014.png)
spalger pushed a commit to spalger/kibana that referenced this issue Jul 30, 2018
Migrate ui/notify/fatal_error to new platform (elastic#20752)
beda8cf 
Fixes elastic#20695

Extracts the "fatal error" handling logic from the `ui/notify` module and reimplements it in the new platform, using EUI for the fatal error page and continuing to support the `fatalError()` and `addFatalErrorCallback()` methods exported by the `ui/notify` module.

![image](https://user-images.githubusercontent.com/1329312/43032175-d37fbafc-8c65-11e8-8f1f-da71f0dac014.png)
spalger pushed a commit that referenced this issue Jul 31, 2018
Migrate ui/notify/fatal_error to new platform (#20752) (#21452)
519a930 
Fixes #20695

Extracts the "fatal error" handling logic from the `ui/notify` module and reimplements it in the new platform, using EUI for the fatal error page and continuing to support the `fatalError()` and `addFatalErrorCallback()` methods exported by the `ui/notify` module.

![image](https://user-images.githubusercontent.com/1329312/43032175-d37fbafc-8c65-11e8-8f1f-da71f0dac014.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spalger