Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/logic/diff/calculation/algorithms - multiLineStringDiffAlgorithm if all three versions are different - scenario ABC does not exceed performance limits when diffing and merging extra large input texts #205014

Closed
kibanamachine opened this issue Dec 19, 2024 · 3 comments · Fixed by #205038
Closed

Failing test: Jest Tests.x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/logic/diff/calculation/algorithms - multiLineStringDiffAlgorithm if all three versions are different - scenario ABC does not exceed performance limits when diffing and merging extra large input texts #205014

kibanamachine opened this issue Dec 19, 2024 · 3 comments · Fixed by #205038
Assignees
@banderror
Labels
8.18 candidate failed-test A test failure on a tracked branch, potentially flaky-test Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area legit-flake Test was triaged and marked as an actual flake. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@kibanamachine
Copy link
Contributor

A test failed on a tracked branch

Error: expect(received).toBeLessThan(expected)

Expected: < 1000
Received:   1142.2760380000109
    at Object.toBeLessThan (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1734641678316778920/elastic/kibana-on-merge/kibana/x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/logic/diff/calculation/algorithms/multi_line_string_diff_algorithm.test.ts:181:35)
    at Promise.then.completed (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1734641678316778920/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1734641678316778920/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1734641678316778920/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:316:40)
    at _runTest (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1734641678316778920/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1734641678316778920/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1734641678316778920/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1734641678316778920/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:121:9)
    at run (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1734641678316778920/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1734641678316778920/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1734641678316778920/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1734641678316778920/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1734641678316778920/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:444:34)

First failure: kibana-on-merge - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Dec 19, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 19, 2024
@kibanamachine kibanamachine added the Team:Detection Rule Management Security Detection Rule Management Team label Dec 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 19, 2024
@banderror banderror added Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area 8.18 candidate labels Dec 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@banderror banderror self-assigned this Dec 20, 2024
@banderror banderror mentioned this issue Dec 20, 2024
Merged
2 tasks
@banderror banderror added the legit-flake Test was triaged and marked as an actual flake. label Dec 20, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 23, 2024
@banderror
[Security Solution] Fix flaky test for multiLineStringDiffAlgorithm (e…
e37f103 
…lastic#205038)

**Fixes: elastic#205014

## Summary

This test on CI runs at least 10x slower than locally, and apparently
even 1000ms timeout is not enough.

Bumping it to 2000ms and hopefully that will be it. Not sure if it makes
sense to bump it even higher, because we need this threshold to be
reasonably low, and more than 2 seconds doesn't sound low for local test
runs.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

(cherry picked from commit 8e0561a)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 23, 2024
@banderror
[Security Solution] Fix flaky test for multiLineStringDiffAlgorithm (e…
46092a7 
…lastic#205038)

**Fixes: elastic#205014

## Summary

This test on CI runs at least 10x slower than locally, and apparently
even 1000ms timeout is not enough.

Bumping it to 2000ms and hopefully that will be it. Not sure if it makes
sense to bump it even higher, because we need this threshold to be
reasonably low, and more than 2 seconds doesn't sound low for local test
runs.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

(cherry picked from commit 8e0561a)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 23, 2024
@banderror
[Security Solution] Fix flaky test for multiLineStringDiffAlgorithm (e…
1a48519 
…lastic#205038)

**Fixes: elastic#205014

## Summary

This test on CI runs at least 10x slower than locally, and apparently
even 1000ms timeout is not enough.

Bumping it to 2000ms and hopefully that will be it. Not sure if it makes
sense to bump it even higher, because we need this threshold to be
reasonably low, and more than 2 seconds doesn't sound low for local test
runs.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

(cherry picked from commit 8e0561a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@banderror banderror

Labels
8.18 candidate failed-test A test failure on a tracked branch, potentially flaky-test Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area legit-flake Test was triaged and marked as an actual flake. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security Solution] Fix flaky test for multiLineStringDiffAlgorithm banderror/kibana
3 participants
@banderror @elasticmachine @kibanamachine