Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Adapt hosts and container views to logs-only data #201752

Closed
crespocarlos opened this issue Nov 26, 2024 · 1 comment · Fixed by #202992
Closed

[Infra] Adapt hosts and container views to logs-only data #201752

crespocarlos opened this issue Nov 26, 2024 · 1 comment · Fixed by #202992
Assignees
@Bluefinger
Labels
enhancement New value added to drive a business result Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@crespocarlos
Copy link
Contributor

Summary

We want the Hosts and Container views to display Logs Rate and Logs Error Rate KPIs when the entity has only logs data.

When an entity is logs-only, the detail view should hide the metrics section and the metrics tab.

Image

Below the callout, we'll display the KPI charts

Image
Ignore click to debug in Discover

Log rate:

  • formula: count()
  • normalizeByUnit: s
  • decimal: 1
  • format: number

Log error rate:

  • formula: count()
  • normalizeByUnit: s
  • decimal: 1
  • format: number
  • filter: log.level: "error" OR log.level: "ERROR" OR error.log.level: "error" OR error.log.level: "ERROR"

AC

  • The hosts and container views show the Log rate and Log error rate KPIs
  • Metrics section and Metrics tab are hidden
  • AddMetricsCallout is displayed above the KPIs
@crespocarlos crespocarlos added enhancement New value added to drive a business result Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Nov 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@Bluefinger Bluefinger self-assigned this Nov 28, 2024
@crespocarlos crespocarlos mentioned this issue Nov 28, 2024
Closed
@Bluefinger Bluefinger mentioned this issue Dec 4, 2024
Merged
Bluefinger added a commit that referenced this issue Dec 10, 2024
@Bluefinger @elasticmachine
[Infra][ObsUX] Hosts & Container Logs only overview (#202992)
305bb1b 
## Summary

Enables a logs only overview for hosts & containers. Disables the
metrics tab as there's no data incoming for metrics, and provides Logs
charts on the overview page detailing the Log Rate (all logs generated)
and Log Error Rate (all recorded errors).


https://github.com/user-attachments/assets/ced14b6d-dd08-4514-9066-6c02c62d5ff8

Closes #201752

## How to test

This is tested using synthtrace data, loading the scenario below:

```
node scripts/synthtrace traces_logs_entities.ts --live
```

This loads a logs-only host, though if other scenarios contain logs only
containers, feel free to use those as well.

* Go to Inventory page. Click on a host or container.
* If it is a logs only host/container, no metrics tab should be shown.
Metrics KPI charts should be replaced with Logs KPI charts (Log Rate and
Log Error Rate).
* If the host/container contains metrics, the metrics tab should be
visible and the normal Metrics KPI charts should be present.

---------

Co-authored-by: Elastic Machine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 10, 2024
@Bluefinger
[Infra][ObsUX] Hosts & Container Logs only overview (elastic#202992)
220ad26 
## Summary

Enables a logs only overview for hosts & containers. Disables the
metrics tab as there's no data incoming for metrics, and provides Logs
charts on the overview page detailing the Log Rate (all logs generated)
and Log Error Rate (all recorded errors).

https://github.com/user-attachments/assets/ced14b6d-dd08-4514-9066-6c02c62d5ff8

Closes elastic#201752

## How to test

This is tested using synthtrace data, loading the scenario below:

```
node scripts/synthtrace traces_logs_entities.ts --live
```

This loads a logs-only host, though if other scenarios contain logs only
containers, feel free to use those as well.

* Go to Inventory page. Click on a host or container.
* If it is a logs only host/container, no metrics tab should be shown.
Metrics KPI charts should be replaced with Logs KPI charts (Log Rate and
Log Error Rate).
* If the host/container contains metrics, the metrics tab should be
visible and the normal Metrics KPI charts should be present.

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 305bb1b)
Bluefinger added a commit to Bluefinger/kibana that referenced this issue Dec 11, 2024
@Bluefinger
[Infra][ObsUX] Hosts & Container Logs only overview (elastic#202992)
7f572f4 
## Summary

Enables a logs only overview for hosts & containers. Disables the
metrics tab as there's no data incoming for metrics, and provides Logs
charts on the overview page detailing the Log Rate (all logs generated)
and Log Error Rate (all recorded errors).

https://github.com/user-attachments/assets/ced14b6d-dd08-4514-9066-6c02c62d5ff8

Closes elastic#201752

## How to test

This is tested using synthtrace data, loading the scenario below:

```
node scripts/synthtrace traces_logs_entities.ts --live
```

This loads a logs-only host, though if other scenarios contain logs only
containers, feel free to use those as well.

* Go to Inventory page. Click on a host or container.
* If it is a logs only host/container, no metrics tab should be shown.
Metrics KPI charts should be replaced with Logs KPI charts (Log Rate and
Log Error Rate).
* If the host/container contains metrics, the metrics tab should be
visible and the normal Metrics KPI charts should be present.

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 305bb1b)

# Conflicts:
#	x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/overview/overview.tsx
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@Bluefinger @elasticmachine @CAWilson94
[Infra][ObsUX] Hosts & Container Logs only overview (elastic#202992)
fb5010a 
## Summary

Enables a logs only overview for hosts & containers. Disables the
metrics tab as there's no data incoming for metrics, and provides Logs
charts on the overview page detailing the Log Rate (all logs generated)
and Log Error Rate (all recorded errors).


https://github.com/user-attachments/assets/ced14b6d-dd08-4514-9066-6c02c62d5ff8

Closes elastic#201752

## How to test

This is tested using synthtrace data, loading the scenario below:

```
node scripts/synthtrace traces_logs_entities.ts --live
```

This loads a logs-only host, though if other scenarios contain logs only
containers, feel free to use those as well.

* Go to Inventory page. Click on a host or container.
* If it is a logs only host/container, no metrics tab should be shown.
Metrics KPI charts should be replaced with Logs KPI charts (Log Rate and
Log Error Rate).
* If the host/container contains metrics, the metrics tab should be
visible and the normal Metrics KPI charts should be present.

---------

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bluefinger Bluefinger

Labels
enhancement New value added to drive a business result Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Infra][ObsUX] Hosts & Container Logs only overview Bluefinger/kibana
3 participants
@crespocarlos @Bluefinger @elasticmachine