Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate chrome to EUI #19992

Closed
epixa opened this issue Jun 18, 2018 · 3 comments
Closed

Migrate chrome to EUI #19992

epixa opened this issue Jun 18, 2018 · 3 comments
Assignees
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@epixa
Copy link
Contributor

epixa commented Jun 18, 2018

In preparation for the K7 design and to support the new platform, we need to replace the chrome UI with EUI components.

We'll take care of this when we move the ui/chrome UI out of the legacy platform and into the new platform, after #20696 is complete.

Should support:

  • App menu
  • Plugin nav controls
  • Breadcrumbs
@epixa epixa added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Jun 18, 2018
@epixa
Copy link
Contributor Author

epixa commented Jun 18, 2018

@spalger I assigned this to you since you need to overhaul the chrome for new platform app bundles anyway, so this work likely just falls out naturally from that.

@spalger spalger changed the title Convert chrome to EUI Migrate chrome to new platform and EUI Jul 12, 2018
spalger pushed a commit that referenced this issue Jul 19, 2018
In order to make the awesome new kfetch api easier to consume in purely TypeScript projects, and since it's a pretty small module with very few dependencies, I converted it to TypeScript.

Along with kfetch I also started a type definition file for `ui/chrome` that we can extend as we go, but will likely be unnecessary after #19992
spalger pushed a commit to spalger/kibana that referenced this issue Jul 19, 2018
In order to make the awesome new kfetch api easier to consume in purely TypeScript projects, and since it's a pretty small module with very few dependencies, I converted it to TypeScript.

Along with kfetch I also started a type definition file for `ui/chrome` that we can extend as we go, but will likely be unnecessary after elastic#19992
spalger pushed a commit that referenced this issue Jul 19, 2018
In order to make the awesome new kfetch api easier to consume in purely TypeScript projects, and since it's a pretty small module with very few dependencies, I converted it to TypeScript.

Along with kfetch I also started a type definition file for `ui/chrome` that we can extend as we go, but will likely be unnecessary after #19992
@joshdover joshdover assigned joshdover and unassigned spalger Sep 20, 2018
@joshdover joshdover changed the title Migrate chrome to new platform and EUI Migrate chrome to EUI Oct 2, 2018
@joshdover
Copy link
Contributor

We decided to implement the K7 EUI header entirely in the old platform, mainly because the plugin API for new platform has not been implemented yet. Plugins interact with the header by placing custom UI as "nav controls" (eg. security's logout UI) and by updating breadcrumbs in the new header.

To unblock K7 for 7.0, we put the new EUI header in the old platform, though still implemented as a React component.

@spalger
Copy link
Contributor

spalger commented Dec 12, 2018

Extracted the migration to the new platform to #27086

@spalger spalger closed this as completed Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

3 participants