Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpoints in the relationships API throw 500 error if object not found #19713

Closed
cuff-links opened this issue Jun 6, 2018 · 2 comments
Closed

Endpoints in the relationships API throw 500 error if object not found #19713

cuff-links opened this issue Jun 6, 2018 · 2 comments
Labels
Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Saved Objects stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@cuff-links
Copy link
Contributor

cuff-links commented Jun 6, 2018 •
edited
Loading

Kibana - Master
Environment: Mac OSX

Steps to reproduce:

  1. Run Kibana Test Server
  2. use CURL to make a GET request to
  3. /api/kibana/management/saved_objects/relationships/search/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx

The /visualization and /index-pattern endpoints do not exhibit this behavior. Only /dashboards and /search.

Expected behavior:
Server should return a 404 for NOT FOUND or a 200 response with an empty Array.

Actual Behavior
Server throws 500 error, thus not revealing whether the issue is with Kibana or ElasticSearch.
cuff-links pushed a commit to cuff-links/kibana that referenced this issue Jun 7, 2018
Skipped two tests due to elastic#19713. Added error handling for rela…
3f7a682 
…tionships API for when no result is found. Return 404.
@cuff-links cuff-links changed the title Endpoints in /savedobjects API throw 500 error if object not found Endpoints in the relationships API throw 500 error if object not found Jun 7, 2018
@cuff-links cuff-links mentioned this issue Jun 7, 2018
Merged
cuff-links added a commit that referenced this issue Jun 20, 2018
@cuff-links
[Management] Relationships API test coverage (#19737)
fea9c42 
* Added coverage around search and dashboard tests.

* Added tests to check for whether the resource is available. If not, return 404.

* Skipped two tests due to #19713. Added error handling for relationships API for when no result is found. Return 404.

* Applied patch file per PR.

* Applied Chris patch and tested locally. No failures.

* Removed ajv and utilised joi for schema validation.

* Fixed package.json.

* Copied package.json description from master.

* Reverted package.json and made proper edit.
cuff-links added a commit to cuff-links/kibana that referenced this issue Jul 13, 2018
@cuff-links
[Management] Relationships API test coverage (elastic#19737)
5a50bd1 
* Added coverage around search and dashboard tests.

* Added tests to check for whether the resource is available. If not, return 404.

* Skipped two tests due to elastic#19713. Added error handling for relationships API for when no result is found. Return 404.

* Applied patch file per PR.

* Applied Chris patch and tested locally. No failures.

* Removed ajv and utilised joi for schema validation.

* Fixed package.json.

* Copied package.json description from master.

* Reverted package.json and made proper edit.
cuff-links added a commit to cuff-links/kibana that referenced this issue Jul 13, 2018
@cuff-links
[Management] Relationships API test coverage (elastic#19737)
2517e5c 
* Added coverage around search and dashboard tests.

* Added tests to check for whether the resource is available. If not, return 404.

* Skipped two tests due to elastic#19713. Added error handling for relationships API for when no result is found. Return 404.

* Applied patch file per PR.

* Applied Chris patch and tested locally. No failures.

* Removed ajv and utilised joi for schema validation.

* Fixed package.json.

* Copied package.json description from master.

* Reverted package.json and made proper edit.
cuff-links pushed a commit that referenced this issue Jul 13, 2018
[Management] Relationships API test coverage (#19737) (#20788)
38c4438 
* Added coverage around search and dashboard tests.

* Added tests to check for whether the resource is available. If not, return 404.

* Skipped two tests due to #19713. Added error handling for relationships API for when no result is found. Return 404.

* Applied patch file per PR.

* Applied Chris patch and tested locally. No failures.

* Removed ajv and utilised joi for schema validation.

* Fixed package.json.

* Copied package.json description from master.

* Reverted package.json and made proper edit.
@cuff-links
Copy link
Contributor Author

/cc @bmcconaghy This was filed a while ago but I don't see any activity on it.

@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Saved Objects Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed :Management DO NOT USE labels Nov 27, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@timroes timroes removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 30, 2018
@joshdover joshdover added the stale Used to mark issues that were closed for being stale label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Saved Objects stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@timroes @cuff-links @joshdover @elasticmachine