[Inventory] Plugin incorrectly displayed in Observability navigation without space permissions #195360
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:EntitiesInventory
Observability entities inventory feature
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
Comments
iblancof
added
bug
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
iblancof
changed the title
iblancof
added
the
Feature:EntitiesInventory
iblancof
added a commit
that referenced
this issue
Oct 10, 2024
… in observabilityShared navigation (#195557) ## Summary Fixes #195360 and #195560 This PR fixes a bug where the Inventory plugin is improperly registered in the ObservabilityShared navigation, even in spaces that lack the required permissions or for user roles that don't have permissions. As a result, the Inventory link appears in the navigation whenever the space/user has access to any other Observability plugin. ### Space permissions #### Before |Space config|ObservabilityShared navigation| |-|-| ||| ##### After |Space config|ObservabilityShared navigation| |-|-| ||| ||| ### User permissions #### Before |Role config|ObservabilityShared navigation| |-|-| ||| #### After |Role config|ObservabilityShared navigation| |-|-| ||<img width="1266" alt="Screenshot 2024-10-09 at 12 52 48" src="https://github.com/user-attachments/assets/5d21bbef-53ca-4d83-84b7-d471a12a40e3">|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 10, 2024
… in observabilityShared navigation (elastic#195557) ## Summary Fixes elastic#195360 and elastic#195560 This PR fixes a bug where the Inventory plugin is improperly registered in the ObservabilityShared navigation, even in spaces that lack the required permissions or for user roles that don't have permissions. As a result, the Inventory link appears in the navigation whenever the space/user has access to any other Observability plugin. ### Space permissions #### Before |Space config|ObservabilityShared navigation| |-|-| ||| ##### After |Space config|ObservabilityShared navigation| |-|-| ||| ||| ### User permissions #### Before |Role config|ObservabilityShared navigation| |-|-| ||| #### After |Role config|ObservabilityShared navigation| |-|-| ||<img width="1266" alt="Screenshot 2024-10-09 at 12 52 48" src="https://github.com/user-attachments/assets/5d21bbef-53ca-4d83-84b7-d471a12a40e3">| (cherry picked from commit 7927ebf)
kibanamachine
added a commit
that referenced
this issue
Oct 10, 2024
…plugin in observabilityShared navigation (#195557) (#195758) # Backport This will backport the following commits from `main` to `8.x`: - [[Inventory] Check permissions before registering the Inventory plugin in observabilityShared navigation (#195557)](#195557) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Irene Blanco","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-10T12:32:37Z","message":"[Inventory] Check permissions before registering the Inventory plugin in observabilityShared navigation (#195557)\n\n## Summary\r\n\r\nFixes #195360 and\r\nhttps://github.com//issues/195560\r\n\r\nThis PR fixes a bug where the Inventory plugin is improperly registered\r\nin the ObservabilityShared navigation, even in spaces that lack the\r\nrequired permissions or for user roles that don't have permissions. As a\r\nresult, the Inventory link appears in the navigation whenever the\r\nspace/user has access to any other Observability plugin.\r\n\r\n\r\n### Space permissions\r\n#### Before\r\n|Space config|ObservabilityShared navigation|\r\n|-|-|\r\n\r\n|||\r\n\r\n\r\n##### After\r\n|Space config|ObservabilityShared navigation|\r\n|-|-|\r\n|||\r\n|||\r\n\r\n\r\n### User permissions\r\n\r\n#### Before\r\n|Role config|ObservabilityShared navigation|\r\n|-|-|\r\n\r\n|||\r\n\r\n\r\n#### After\r\n|Role config|ObservabilityShared navigation|\r\n|-|-|\r\n\r\n||<img\r\nwidth=\"1266\" alt=\"Screenshot 2024-10-09 at 12 52 48\"\r\nsrc=\"https://github.com/user-attachments/assets/5d21bbef-53ca-4d83-84b7-d471a12a40e3\">|","sha":"7927ebf2a6e3bc459acb6d3217cb87ba8f837e09","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"title":"[Inventory] Check permissions before registering the Inventory plugin in observabilityShared navigation","number":195557,"url":"https://github.com/elastic/kibana/pull/195557","mergeCommit":{"message":"[Inventory] Check permissions before registering the Inventory plugin in observabilityShared navigation (#195557)\n\n## Summary\r\n\r\nFixes #195360 and\r\nhttps://github.com//issues/195560\r\n\r\nThis PR fixes a bug where the Inventory plugin is improperly registered\r\nin the ObservabilityShared navigation, even in spaces that lack the\r\nrequired permissions or for user roles that don't have permissions. As a\r\nresult, the Inventory link appears in the navigation whenever the\r\nspace/user has access to any other Observability plugin.\r\n\r\n\r\n### Space permissions\r\n#### Before\r\n|Space config|ObservabilityShared navigation|\r\n|-|-|\r\n\r\n|||\r\n\r\n\r\n##### After\r\n|Space config|ObservabilityShared navigation|\r\n|-|-|\r\n|||\r\n|||\r\n\r\n\r\n### User permissions\r\n\r\n#### Before\r\n|Role config|ObservabilityShared navigation|\r\n|-|-|\r\n\r\n|||\r\n\r\n\r\n#### After\r\n|Role config|ObservabilityShared navigation|\r\n|-|-|\r\n\r\n||<img\r\nwidth=\"1266\" alt=\"Screenshot 2024-10-09 at 12 52 48\"\r\nsrc=\"https://github.com/user-attachments/assets/5d21bbef-53ca-4d83-84b7-d471a12a40e3\">|","sha":"7927ebf2a6e3bc459acb6d3217cb87ba8f837e09"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195557","number":195557,"mergeCommit":{"message":"[Inventory] Check permissions before registering the Inventory plugin in observabilityShared navigation (#195557)\n\n## Summary\r\n\r\nFixes #195360 and\r\nhttps://github.com//issues/195560\r\n\r\nThis PR fixes a bug where the Inventory plugin is improperly registered\r\nin the ObservabilityShared navigation, even in spaces that lack the\r\nrequired permissions or for user roles that don't have permissions. As a\r\nresult, the Inventory link appears in the navigation whenever the\r\nspace/user has access to any other Observability plugin.\r\n\r\n\r\n### Space permissions\r\n#### Before\r\n|Space config|ObservabilityShared navigation|\r\n|-|-|\r\n\r\n|||\r\n\r\n\r\n##### After\r\n|Space config|ObservabilityShared navigation|\r\n|-|-|\r\n|||\r\n|||\r\n\r\n\r\n### User permissions\r\n\r\n#### Before\r\n|Role config|ObservabilityShared navigation|\r\n|-|-|\r\n\r\n|||\r\n\r\n\r\n#### After\r\n|Role config|ObservabilityShared navigation|\r\n|-|-|\r\n\r\n||<img\r\nwidth=\"1266\" alt=\"Screenshot 2024-10-09 at 12 52 48\"\r\nsrc=\"https://github.com/user-attachments/assets/5d21bbef-53ca-4d83-84b7-d471a12a40e3\">|","sha":"7927ebf2a6e3bc459acb6d3217cb87ba8f837e09"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Irene Blanco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description
The new Inventory plugin is being incorrectly registered in the
ObservabilitySharednavigation, even if the space does not have the necessary permissions to allow it. This causes the Inventory link to be displayed in the navigation, despite it not being accessible in the current space.Expected Behavior
The Inventory plugin should only be registered in the
ObservabilitySharednavigation if the space has the appropriate permissions configured.Steps to Reproduce
ObservabilitySharednavigation to see if the Inventory link is displayed.Current Result: The Inventory link is shown.
Expected Result: The Inventory link should not be visible.
Proposed Fix
Adjust the plugin registration to include a permissions check before adding it to the shared navigation.
The text was updated successfully, but these errors were encountered: