Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vega] View dimensions not properly updated when resized #194861

Closed
nickofthyme opened this issue Oct 3, 2024 · 1 comment · Fixed by #194330
Closed

[Vega] View dimensions not properly updated when resized #194861

nickofthyme opened this issue Oct 3, 2024 · 1 comment · Fixed by #194330
Assignees
@nickofthyme
Labels
bug Fixes for quality problems that affect the customer experience Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@nickofthyme
Copy link
Contributor

Kibana version:

8.x

Describe the bug:

When resizing a vega visualization, the resize logic may not pickup the latest dimension causing the view height to exceed the panel height.

Steps to reproduce:

  1. Load sample logs data
  2. Go to canvas, create a new workpad
  3. Add the [Logs] Machine OS and Destination Sankey Chart chart to the workpad
  4. Resize the vis panel to be larger then smaller
  5. Notice the state of the panel, with scrollbars.

Expected behavior:

View is correctly resized with latest panel dimensions

Screenshots (if relevant):

Zight.Recording.2024-10-03.at.11.23.52.AM.mp4
@nickofthyme nickofthyme added bug Fixes for quality problems that affect the customer experience Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 3, 2024
@nickofthyme nickofthyme self-assigned this Oct 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@nickofthyme nickofthyme mentioned this issue Oct 3, 2024
Merged
1 task
nickofthyme added a commit to nickofthyme/kibana that referenced this issue Oct 3, 2024
@nickofthyme
fix resizing issue elastic#194861
81a7703
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 7, 2024
@nickofthyme
[Vega] Fix element sizing issues in fullscreen mode (elastic#194330)
cfd7686 
- Fixes elastic#194011 where a Vega visualization does not respect the enclosing
element dimensions.
- Fixes elastic#194861 where resizing Vega visualization panel fails to update to the
latest panel dimensions causing scroll bars.

(cherry picked from commit 55c2fd7)
kibanamachine added a commit that referenced this issue Oct 8, 2024
@kibanamachine @nickofthyme
[8.x] [Vega] Fix element sizing issues in fullscreen mode (#194330) (#…
c4e4028 
…195328)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Vega] Fix element sizing issues in fullscreen mode
(#194330)](#194330)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nick
Partridge","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-07T22:20:27Z","message":"[Vega]
Fix element sizing issues in fullscreen mode (#194330)\n\n- Fixes
#194011 where a Vega visualization does not respect the
enclosing\r\nelement dimensions.\r\n- Fixes #194861 where resizing Vega
visualization panel fails to update to the\r\nlatest panel dimensions
causing scroll
bars.","sha":"55c2fd7fc1ef292961d5d69d20d1711b1fbbd468","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Vega","Team:Visualizations","v9.0.0","backport:prev-minor"],"title":"[Vega]
Fix element sizing issues in fullscreen
mode","number":194330,"url":"https://github.com/elastic/kibana/pull/194330","mergeCommit":{"message":"[Vega]
Fix element sizing issues in fullscreen mode (#194330)\n\n- Fixes
#194011 where a Vega visualization does not respect the
enclosing\r\nelement dimensions.\r\n- Fixes #194861 where resizing Vega
visualization panel fails to update to the\r\nlatest panel dimensions
causing scroll
bars.","sha":"55c2fd7fc1ef292961d5d69d20d1711b1fbbd468"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194330","number":194330,"mergeCommit":{"message":"[Vega]
Fix element sizing issues in fullscreen mode (#194330)\n\n- Fixes
#194011 where a Vega visualization does not respect the
enclosing\r\nelement dimensions.\r\n- Fixes #194861 where resizing Vega
visualization panel fails to update to the\r\nlatest panel dimensions
causing scroll
bars.","sha":"55c2fd7fc1ef292961d5d69d20d1711b1fbbd468"}}]}] BACKPORT-->

Co-authored-by: Nick Partridge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickofthyme nickofthyme

Labels
bug Fixes for quality problems that affect the customer experience Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Vega] Fix element sizing issues in fullscreen mode nickofthyme/kibana
2 participants
@elasticmachine @nickofthyme