Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution][Bug] Custom dashboards list don't load #194733

Closed
semd opened this issue Oct 2, 2024 · 1 comment · Fixed by #195277
Closed

[SecuritySolution][Bug] Custom dashboards list don't load #194733

semd opened this issue Oct 2, 2024 · 1 comment · Fixed by #195277
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@semd
Copy link
Contributor

semd commented Oct 2, 2024

Summary

For some reason, the custom dashboard list never finishes loading.

Version: 8.16

Image

@semd semd added bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Oct 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@semd semd changed the title [Security Solution][Bug] Custom dashboards list don't load [SecuritySolution][Bug] Custom dashboards list don't load Oct 2, 2024
@Heenawter Heenawter self-assigned this Oct 7, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 7, 2024
)

Closes elastic#194733

## Summary

In elastic#193644, I forgot to remove
references to the old `servicesReady` promise - this caused an issue
where it never resolved `true`, so anywhere that depended on this would
be stuck in a loading state. This PR fixes this by replacing all
instances of `servicesReady` with the new
`untilPluginStartServicesReady` promise.

Specifically, this fixes the exported `DashboardListingTable` that the
Security page uses:

- **Before:**

https://github.com/user-attachments/assets/78fc8ad8-7bff-43bf-95ec-d52f4da91371

- **After:**

https://github.com/user-attachments/assets/af1be9d3-9af5-4a30-9b5d-bc4352214a97

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 10271a2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants