[Lens] Include and exclude values can be the same in advanced config for lens bar chart #194639
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Lens
good first issue
low hanging fruit
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
Comments
bhavyarm
added
bug
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
1 task
tkajtoch
pushed a commit
to tkajtoch/kibana
that referenced
this issue
Nov 12, 2024
## Summary Fixes elastic#194639 - This PR adds filtering logic to: - `onChangeIncludeExcludeOptions` - `onCreateOption` - `onIncludeRegexChangeToDebounce` - `onExcludeRegexChangeToDebounce` These changes prevent the include and exclude fields from having the same values simultaneously. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios https://github.com/user-attachments/assets/8f848c2a-0bea-46c6-b335-b04d62c12aef --------- Co-authored-by: Marta Bondyra <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Nov 14, 2024
## Summary Fixes elastic#194639 - This PR adds filtering logic to: - `onChangeIncludeExcludeOptions` - `onCreateOption` - `onIncludeRegexChangeToDebounce` - `onExcludeRegexChangeToDebounce` These changes prevent the include and exclude fields from having the same values simultaneously. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios https://github.com/user-attachments/assets/8f848c2a-0bea-46c6-b335-b04d62c12aef --------- Co-authored-by: Marta Bondyra <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 750e578)
kibanamachine
added a commit
that referenced
this issue
Nov 14, 2024
…200133) # Backport This will backport the following commits from `main` to `8.x`: - [[lens] Prevent identical include and exclude values (#197628)](#197628) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Oyelola Victoria","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-11T16:48:23Z","message":"[lens] Prevent identical include and exclude values (#197628)\n\n## Summary\r\n\r\nFixes #194639\r\n\r\n- This PR adds filtering logic to:\r\n - `onChangeIncludeExcludeOptions`\r\n - `onCreateOption`\r\n - `onIncludeRegexChangeToDebounce` \r\n - `onExcludeRegexChangeToDebounce`\r\n\r\nThese changes prevent the include and exclude fields from having the\r\nsame values simultaneously.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8f848c2a-0bea-46c6-b335-b04d62c12aef\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"750e578f2867d1ad6bf2f1f7506a1d75f2d77d05","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","backport missing","💝community","v9.0.0","backport:current-major"],"title":"[Lens] Prevent identical include and exclude values","number":197628,"url":"https://github.com/elastic/kibana/pull/197628","mergeCommit":{"message":"[lens] Prevent identical include and exclude values (#197628)\n\n## Summary\r\n\r\nFixes #194639\r\n\r\n- This PR adds filtering logic to:\r\n - `onChangeIncludeExcludeOptions`\r\n - `onCreateOption`\r\n - `onIncludeRegexChangeToDebounce` \r\n - `onExcludeRegexChangeToDebounce`\r\n\r\nThese changes prevent the include and exclude fields from having the\r\nsame values simultaneously.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8f848c2a-0bea-46c6-b335-b04d62c12aef\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"750e578f2867d1ad6bf2f1f7506a1d75f2d77d05"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197628","number":197628,"mergeCommit":{"message":"[lens] Prevent identical include and exclude values (#197628)\n\n## Summary\r\n\r\nFixes #194639\r\n\r\n- This PR adds filtering logic to:\r\n - `onChangeIncludeExcludeOptions`\r\n - `onCreateOption`\r\n - `onIncludeRegexChangeToDebounce` \r\n - `onExcludeRegexChangeToDebounce`\r\n\r\nThese changes prevent the include and exclude fields from having the\r\nsame values simultaneously.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8f848c2a-0bea-46c6-b335-b04d62c12aef\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"750e578f2867d1ad6bf2f1f7506a1d75f2d77d05"}}]}] BACKPORT--> Co-authored-by: Oyelola Victoria <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this issue
Nov 18, 2024
## Summary Fixes elastic#194639 - This PR adds filtering logic to: - `onChangeIncludeExcludeOptions` - `onCreateOption` - `onIncludeRegexChangeToDebounce` - `onExcludeRegexChangeToDebounce` These changes prevent the include and exclude fields from having the same values simultaneously. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios https://github.com/user-attachments/assets/8f848c2a-0bea-46c6-b335-b04d62c12aef --------- Co-authored-by: Marta Bondyra <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kibana version: 8.16.0 latest snapshot
Browser version: chrome latest
Browser OS version: os x
Original install method (e.g. download page, yum, from source, etc.): from snapshots
Describe the bug: If user add some values to "include values" and then adds the same values to "Exclude values" in advanced config for breakdown for lens bar chart, Kibana doesn't update the values from excludes in include. User has to do this manually.
Can we fix this so the included and excluded list doesn't show values from each other's list.
The text was updated successfully, but these errors were encountered: