Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update role - match wording of button and toast #194406

Closed
jeramysoucy opened this issue Sep 30, 2024 · 1 comment · Fixed by #194427
Closed

Update role - match wording of button and toast #194406

jeramysoucy opened this issue Sep 30, 2024 · 1 comment · Fixed by #194427
Assignees
@SiddharthMantri
Labels
Feature:Users/Roles/API Keys Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@jeramysoucy
Copy link
Contributor

When editing a role the UI displays a form accept button titled "Update role", but when the button is activated and the toast summarizing the result of the actions states that the role was "saved".

It would be ideal if the wording for the both the button and toast message matched.

Image

Image
@jeramysoucy jeramysoucy added Feature:Users/Roles/API Keys Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Sep 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@SiddharthMantri SiddharthMantri self-assigned this Sep 30, 2024
@SiddharthMantri SiddharthMantri mentioned this issue Sep 30, 2024
Merged
tiansivive pushed a commit to tiansivive/kibana that referenced this issue Oct 7, 2024
@SiddharthMantri @jeramysoucy
@elasticmachine @tiansivive
[Roles] Fix wording for updating roles toast to match button text (el…
38d610c 
…astic#194427)

Closes elastic#194406

## Summary

Fix wording for Roles update toast to match button when updating an
existing role.

### Screenshots

<img width="746" alt="image"
src="https://github.com/user-attachments/assets/674a57f3-5a5a-445a-9266-8b55526aef72">


### Release notes
Changes wording for toast message when updating an existing role
successfully. The toast now matches the button to say `Updated role`

---------

Co-authored-by: Jeramy Soucy <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SiddharthMantri SiddharthMantri

Labels
Feature:Users/Roles/API Keys Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Roles] Fix wording for updating roles toast to match button text SiddharthMantri/kibana
3 participants
@SiddharthMantri @elasticmachine @jeramysoucy