Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Prevent Add from library table type column from truncating #193750

Closed
nickofthyme opened this issue Sep 23, 2024 · 2 comments · Fixed by #194388
Closed

[Dashboard] Prevent Add from library table type column from truncating #193750

nickofthyme opened this issue Sep 23, 2024 · 2 comments · Fixed by #194388
Assignees
@sebelga
Labels
Feature:Dashboard Dashboard related features good first issue low hanging fruit papercut Small "burr" in the product that we should fix. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@nickofthyme
Copy link
Contributor

nickofthyme commented Sep 23, 2024 •
edited
Loading

Tiny UI request - The Type column should be wide enough to prevent the header text from being truncated. This is saving a few pixels of space at the cost of lessor context being shared with the user.

Image

Expected

Image
@nickofthyme nickofthyme added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Sep 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese added good first issue low hanging fruit Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Sep 25, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@Ruby-rc Ruby-rc mentioned this issue Sep 30, 2024
Merged
@lucastemb lucastemb mentioned this issue Oct 5, 2024
Closed
@sebelga sebelga mentioned this issue Oct 16, 2024
Closed
@petrklapka petrklapka added the papercut Small "burr" in the product that we should fix. label Oct 17, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 18, 2024
@Ruby-rc
style(ux-dashboards): fixed width from saved object type column (elas…
77c027a 
…tic#194388)

## Summary
Fixes elastic#193750

Removed the fixed width of 50px from the type column in the saved object
finder UI to allow for more flexible and responsive table formatting.

Before:

![image](https://github.com/user-attachments/assets/df4d312c-8956-482e-a91e-643831e7364e)

Now:

![image](https://github.com/user-attachments/assets/987f37e6-b14e-41c5-a435-ce2539936c7c)

But I'm not sure if changing the width to 70px is more appropriate

![image](https://github.com/user-attachments/assets/f6a52146-bc7a-4d65-b86c-a7c1393c88f5)

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
(cherry picked from commit febb198)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 18, 2024
@Ruby-rc
style(ux-dashboards): fixed width from saved object type column (elas…
4079f3c 
…tic#194388)

## Summary
Fixes elastic#193750

Removed the fixed width of 50px from the type column in the saved object
finder UI to allow for more flexible and responsive table formatting.

Before:

![image](https://github.com/user-attachments/assets/df4d312c-8956-482e-a91e-643831e7364e)

Now:

![image](https://github.com/user-attachments/assets/987f37e6-b14e-41c5-a435-ce2539936c7c)

But I'm not sure if changing the width to 70px is more appropriate

![image](https://github.com/user-attachments/assets/f6a52146-bc7a-4d65-b86c-a7c1393c88f5)

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
(cherry picked from commit febb198)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 18, 2024
@Ruby-rc
style(ux-dashboards): fixed width from saved object type column (elas…
37ae683 
…tic#194388)

## Summary
Fixes elastic#193750

Removed the fixed width of 50px from the type column in the saved object
finder UI to allow for more flexible and responsive table formatting.

Before:

![image](https://github.com/user-attachments/assets/df4d312c-8956-482e-a91e-643831e7364e)

Now:

![image](https://github.com/user-attachments/assets/987f37e6-b14e-41c5-a435-ce2539936c7c)

But I'm not sure if changing the width to 70px is more appropriate

![image](https://github.com/user-attachments/assets/f6a52146-bc7a-4d65-b86c-a7c1393c88f5)

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
(cherry picked from commit febb198)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebelga sebelga

Labels
Feature:Dashboard Dashboard related features good first issue low hanging fruit papercut Small "burr" in the product that we should fix. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
5 participants
@nreese @sebelga @elasticmachine @nickofthyme @petrklapka