Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Integrate Borealis color palette #192848

Closed
4 tasks done
Tracked by #192814
teresaalvarezsoler opened this issue Sep 13, 2024 · 4 comments · Fixed by #201015
Closed
4 tasks done
Tracked by #192814

[Lens] Integrate Borealis color palette #192848

teresaalvarezsoler opened this issue Sep 13, 2024 · 4 comments · Fixed by #201015
Assignees
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@teresaalvarezsoler
Copy link

teresaalvarezsoler commented Sep 13, 2024

Description

The new Borealis color palette needs to be tested for all chart types to make sure they both work well for all edge cases.

Tasks

  • Color mapping: Include the palette as additional option
  • Color by value: Replace existing palettes with the new colors -- to ensure backwards compatibility, existing charts can keep their colors as custom
  • Dimensions Replace the colors in the color picker
  • Partition charts make sure the multi-layer coloring strategy works in partition charts

Testing

Test the following scenarios:

  • New color palettes work for all chart types
  • Infinite loop mechanism works for high-dimensional fields
  • New color palettes work with the "sync colors" setting in the dashboard
  • Existing charts doesn't change their default colors
  • New palette works for ES|QL charts
@teresaalvarezsoler teresaalvarezsoler added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Sep 13, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@florent-leborgne
Copy link
Contributor

Hi! Here are some naming suggestions for the new, and current, color palettes:

the 2 new palettes

  • Elastic (default) //new one, giving it an actual name instead of just Default
  • Elastic high contrast //new one too, same name as the default one, + stating that it's the high contrast version of the same

the existing ones

  • Kibana 7.0 //(previous "default" renamed)
  • Kibana 4.0 //(previous "Kibana legacy" renamed)
  • Elastic classic //(previous "Elastic brand" renamed. The new palettes are also on brand, so I figured their names should reflect this, and requires renaming this one)

The new ones don't get any temporality in the way they're named, to reinforce that they're the current best and latest.
The older ones get renamed to add that temporality notion so that users know they're what they've seen/used in the past, in case they get nostalgic of the old days.

Let me know what you think and we can refine as needed.

@nickofthyme
Copy link
Contributor

nickofthyme commented Sep 17, 2024

@gvnmagni in the meeting this week it was mentioned to use prefers-contrast. To me that would mean we have a user setting toggle, then we use this under the hood to pick the high contrast color palette based on the selected palette. Assuming not all palettes have a high contrast version, I don't know how/if we want to alert the user when the current palette does not support high contrast.

In this flow there would be no need for the explicit naming of the Elastic high contrast palette.

@gvnmagni
Copy link

This is a good point, technically this setting would be available only if the user selected the new color palette as a default because, as you correctly pointed out, there is no alternative for other palettes.

Would this setting be disabled if the user didn't choose to move to the new palette? How do you see something like that, can we do it?

@markov00 markov00 self-assigned this Oct 16, 2024
@nickofthyme nickofthyme assigned nickofthyme and unassigned markov00 Oct 16, 2024
@markov00 markov00 changed the title [Lens] New color palette implementation for testing [Lens] Integrate Borealis color palette Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants