Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Anomaly detection: Hide Top influencers panel for jobs without influencers #192679

Closed
peteharverson opened this issue Sep 12, 2024 · 1 comment
Closed

[ML] Anomaly detection: Hide Top influencers panel for jobs without influencers #192679

peteharverson opened this issue Sep 12, 2024 · 1 comment
Assignees
@rbrtj
Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection good first issue low hanging fruit :ml v8.16.0

Comments

@peteharverson
Copy link
Contributor

The 'Top influencers' panel in the Anomaly Explorer should only be shown if the selected job(s) contain influencers. Current behavior is that the panel is being shown even for jobs without influencers:

Image

Regression introduced since 8.15, possibly introduced by #189729. Behavior on 8.15.1:

Image

A functional test should also be added to validate the behavior with no influencers.
@peteharverson peteharverson added :ml bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection v8.16.0 labels Sep 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@rbrtj rbrtj mentioned this issue Sep 16, 2024
Merged
@peteharverson peteharverson added the good first issue low hanging fruit label Sep 19, 2024
rbrtj added a commit that referenced this issue Sep 20, 2024
@rbrtj
[ML] Anomaly Explorer: Hide top influencers panel for jobs without in…
23b2595 
…fluencers (#192987)

# Summary

Fix for [#192679](#192679)
Hiding the top influencers panel when there are no influencers for the
selected job.
Added a functional test to ensure the panel is hidden.
Expanded a few types to improve type safety.
@rbrtj rbrtj closed this as completed Sep 20, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Sep 20, 2024
@rbrtj
[ML] Anomaly Explorer: Hide top influencers panel for jobs without in…
6a9e903 
…fluencers (elastic#192987)

# Summary

Fix for [elastic#192679](elastic#192679)
Hiding the top influencers panel when there are no influencers for the
selected job.
Added a functional test to ensure the panel is hidden.
Expanded a few types to improve type safety.

(cherry picked from commit 23b2595)
kibanamachine added a commit that referenced this issue Sep 23, 2024
@kibanamachine @rbrtj
[8.x] [ML] Anomaly Explorer: Hide top influencers panel for jobs with…
5f2de6d 
…out influencers (#192987) (#193568)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Anomaly Explorer: Hide top influencers panel for jobs without
influencers (#192987)](#192987)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-20T12:06:29Z","message":"[ML]
Anomaly Explorer: Hide top influencers panel for jobs without
influencers (#192987)\n\n# Summary\r\n\r\nFix for
[#192679](https://github.com/elastic/kibana/issues/192679)\r\nHiding the
top influencers panel when there are no influencers for the\r\nselected
job.\r\nAdded a functional test to ensure the panel is
hidden.\r\nExpanded a few types to improve type
safety.","sha":"23b2595be39401214a1ef9e39b684f917020b9ad","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug",":ml","release_note:skip","v9.0.0","Team:ML","backport:prev-minor","v8.16.0"],"title":"[ML]
Anomaly Explorer: Hide top influencers panel for jobs without
influencers","number":192987,"url":"https://github.com/elastic/kibana/pull/192987","mergeCommit":{"message":"[ML]
Anomaly Explorer: Hide top influencers panel for jobs without
influencers (#192987)\n\n# Summary\r\n\r\nFix for
[#192679](https://github.com/elastic/kibana/issues/192679)\r\nHiding the
top influencers panel when there are no influencers for the\r\nselected
job.\r\nAdded a functional test to ensure the panel is
hidden.\r\nExpanded a few types to improve type
safety.","sha":"23b2595be39401214a1ef9e39b684f917020b9ad"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192987","number":192987,"mergeCommit":{"message":"[ML]
Anomaly Explorer: Hide top influencers panel for jobs without
influencers (#192987)\n\n# Summary\r\n\r\nFix for
[#192679](https://github.com/elastic/kibana/issues/192679)\r\nHiding the
top influencers panel when there are no influencers for the\r\nselected
job.\r\nAdded a functional test to ensure the panel is
hidden.\r\nExpanded a few types to improve type
safety.","sha":"23b2595be39401214a1ef9e39b684f917020b9ad"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbrtj rbrtj

Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection good first issue low hanging fruit :ml v8.16.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@peteharverson @elasticmachine @rbrtj