-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metric threshold] Create rule flyout does not show the condition fields #192439
Labels
bug
Fixes for quality problems that affect the customer experience
Team:obs-ux-management
Observability Management User Experience Team
Comments
maryam-saeidi
added
bug
Fixes for quality problems that affect the customer experience
Team:obs-ux-management
Observability Management User Experience Team
labels
Sep 10, 2024
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Sep 13, 2024
…eshold flyout (elastic#192736) Closes elastic#192439 ## Summary This PR reverts this [line](https://github.com/elastic/kibana/pull/191948/files#diff-2dd82a791bba3d995e9e6b35d4a973053f166351cc6025a5cd1d24dc789766aeR48) in a previous [PR](elastic#191948) that caused an issue in loading the metric threshold flyout on the observability alerts page. | Before ❌ | After ✅ | |---|---| |![Image](https://github.com/user-attachments/assets/3c0b8812-8cd9-4769-bd20-ab10f559009b)|![Image](https://github.com/user-attachments/assets/9823e691-ce18-4c00-8748-ce5797a19943)| I also added a small test that fails before this fix. (cherry picked from commit c304b34)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Sep 13, 2024
…eshold flyout (elastic#192736) Closes elastic#192439 ## Summary This PR reverts this [line](https://github.com/elastic/kibana/pull/191948/files#diff-2dd82a791bba3d995e9e6b35d4a973053f166351cc6025a5cd1d24dc789766aeR48) in a previous [PR](elastic#191948) that caused an issue in loading the metric threshold flyout on the observability alerts page. | Before ❌ | After ✅ | |---|---| |![Image](https://github.com/user-attachments/assets/3c0b8812-8cd9-4769-bd20-ab10f559009b)|![Image](https://github.com/user-attachments/assets/9823e691-ce18-4c00-8748-ce5797a19943)| I also added a small test that fails before this fix. (cherry picked from commit c304b34)
kibanamachine
added a commit
that referenced
this issue
Sep 13, 2024
…ic threshold flyout (#192736) (#192825) # Backport This will backport the following commits from `main` to `8.x`: - [[Metric threshold] Fix the condition not showing up in the metric threshold flyout (#192736)](#192736) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-13T09:10:15Z","message":"[Metric threshold] Fix the condition not showing up in the metric threshold flyout (#192736)\n\nCloses #192439\r\n\r\n## Summary\r\n\r\nThis PR reverts this\r\n[line](https://github.com/elastic/kibana/pull/191948/files#diff-2dd82a791bba3d995e9e6b35d4a973053f166351cc6025a5cd1d24dc789766aeR48)\r\nin a previous [PR](#191948) that\r\ncaused an issue in loading the metric threshold flyout on the\r\nobservability alerts page.\r\n\r\n| Before ❌ | After ✅ |\r\n|---|---|\r\n\r\n|![Image](https://github.com/user-attachments/assets/3c0b8812-8cd9-4769-bd20-ab10f559009b)|![Image](https://github.com/user-attachments/assets/9823e691-ce18-4c00-8748-ce5797a19943)|\r\n\r\nI also added a small test that fails before this fix.","sha":"c304b34e0edd90dedcb67dff10da6472d4a823c0","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability"],"title":"[Metric threshold] Fix the condition not showing up in the metric threshold flyout","number":192736,"url":"https://github.com/elastic/kibana/pull/192736","mergeCommit":{"message":"[Metric threshold] Fix the condition not showing up in the metric threshold flyout (#192736)\n\nCloses #192439\r\n\r\n## Summary\r\n\r\nThis PR reverts this\r\n[line](https://github.com/elastic/kibana/pull/191948/files#diff-2dd82a791bba3d995e9e6b35d4a973053f166351cc6025a5cd1d24dc789766aeR48)\r\nin a previous [PR](#191948) that\r\ncaused an issue in loading the metric threshold flyout on the\r\nobservability alerts page.\r\n\r\n| Before ❌ | After ✅ |\r\n|---|---|\r\n\r\n|![Image](https://github.com/user-attachments/assets/3c0b8812-8cd9-4769-bd20-ab10f559009b)|![Image](https://github.com/user-attachments/assets/9823e691-ce18-4c00-8748-ce5797a19943)|\r\n\r\nI also added a small test that fails before this fix.","sha":"c304b34e0edd90dedcb67dff10da6472d4a823c0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192736","number":192736,"mergeCommit":{"message":"[Metric threshold] Fix the condition not showing up in the metric threshold flyout (#192736)\n\nCloses #192439\r\n\r\n## Summary\r\n\r\nThis PR reverts this\r\n[line](https://github.com/elastic/kibana/pull/191948/files#diff-2dd82a791bba3d995e9e6b35d4a973053f166351cc6025a5cd1d24dc789766aeR48)\r\nin a previous [PR](#191948) that\r\ncaused an issue in loading the metric threshold flyout on the\r\nobservability alerts page.\r\n\r\n| Before ❌ | After ✅ |\r\n|---|---|\r\n\r\n|![Image](https://github.com/user-attachments/assets/3c0b8812-8cd9-4769-bd20-ab10f559009b)|![Image](https://github.com/user-attachments/assets/9823e691-ce18-4c00-8748-ce5797a19943)|\r\n\r\nI also added a small test that fails before this fix.","sha":"c304b34e0edd90dedcb67dff10da6472d4a823c0"}}]}] BACKPORT--> Co-authored-by: Maryam Saeidi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Team:obs-ux-management
Observability Management User Experience Team
Kibana version: 8.16, main
Describe the bug:
Opening the metric threshold rule type flyout on the observability > alerts > rules page does not show all the fields:
Steps to reproduce:
Expected behavior:
Showing all the rule fields in the create flyout.
The text was updated successfully, but these errors were encountered: