Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inventory] Add sharing button #192325

Closed
smith opened this issue Sep 8, 2024 · 2 comments · Fixed by #194535
Closed

[Inventory] Add sharing button #192325

smith opened this issue Sep 8, 2024 · 2 comments · Fixed by #194535
Assignees
Labels
enhancement New value added to drive a business result Feature:EntitiesInventory Observability entities inventory feature Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@smith
Copy link
Contributor

smith commented Sep 8, 2024

In order to share links to the inventory with other users, there should be a share button that gives the users the option of sharing a URL to the page

Use the share plugin to add this.

✔ Acceptance criteria

  • A share button is in the top menu
  • It allows users to share a short link to the page.
@smith smith added enhancement New value added to drive a business result Feature:EntitiesInventory Observability entities inventory feature Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Sep 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@kpatticha kpatticha changed the title Inventory sharing [Inventory] Add sharing button Sep 12, 2024
@crespocarlos
Copy link
Contributor

crespocarlos commented Sep 16, 2024

I think this depends on #192329. We need first to store the search data in the querystring to make sure the sharing works.

@Bluefinger Bluefinger self-assigned this Sep 27, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 2, 2024
## Summary

Adds a Share link button to the Inventory page, next to the Add Data
button on the top right of the screen. This creates a short link and
copies it to the user's clipboard so they can share it.

https://github.com/user-attachments/assets/42c7b2f9-da19-4ced-8d28-211234bea4cf

## How to Test

- Log in and go to Inventory page. Ensure there is data loaded and
entities are showing.
- Put a filter on the inventory to restrict the results to a given
state, such as `entity.type : "service"`.
- Click on the `Share` button and wait until you get a success toast
message.
- Open a new empty tab on the browser and paste the link into the url
bar to navigate to the page.

**Expected Result**: The page should navigate to the Inventory page and
load into the same state as the page on the original browser tab.

Closes elastic#192325

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 574af41)
kibanamachine added a commit that referenced this issue Oct 2, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inventory] Add Sharing button
(#194535)](#194535)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da
Silva","email":"goncalo.rica@elastic.co"},"sourceCommit":{"committedDate":"2024-10-02T09:19:44Z","message":"[Inventory]
Add Sharing button (#194535)\n\n## Summary\r\n\r\nAdds a Share link
button to the Inventory page, next to the Add Data\r\nbutton on the top
right of the screen. This creates a short link and\r\ncopies it to the
user's clipboard so they can share
it.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/42c7b2f9-da19-4ced-8d28-211234bea4cf\r\n\r\n##
How to Test\r\n\r\n- Log in and go to Inventory page. Ensure there is
data loaded and\r\nentities are showing.\r\n- Put a filter on the
inventory to restrict the results to a given\r\nstate, such as
`entity.type : \"service\"`.\r\n- Click on the `Share` button and wait
until you get a success toast\r\nmessage.\r\n- Open a new empty tab on
the browser and paste the link into the url\r\nbar to navigate to the
page.\r\n\r\n**Expected Result**: The page should navigate to the
Inventory page and\r\nload into the same state as the page on the
original browser tab.\r\n\r\nCloses
#192325\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"574af418a2dd30ad19eee0a4c49b82b41c489470","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"title":"[Inventory]
Add Sharing
button","number":194535,"url":"https://github.com/elastic/kibana/pull/194535","mergeCommit":{"message":"[Inventory]
Add Sharing button (#194535)\n\n## Summary\r\n\r\nAdds a Share link
button to the Inventory page, next to the Add Data\r\nbutton on the top
right of the screen. This creates a short link and\r\ncopies it to the
user's clipboard so they can share
it.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/42c7b2f9-da19-4ced-8d28-211234bea4cf\r\n\r\n##
How to Test\r\n\r\n- Log in and go to Inventory page. Ensure there is
data loaded and\r\nentities are showing.\r\n- Put a filter on the
inventory to restrict the results to a given\r\nstate, such as
`entity.type : \"service\"`.\r\n- Click on the `Share` button and wait
until you get a success toast\r\nmessage.\r\n- Open a new empty tab on
the browser and paste the link into the url\r\nbar to navigate to the
page.\r\n\r\n**Expected Result**: The page should navigate to the
Inventory page and\r\nload into the same state as the page on the
original browser tab.\r\n\r\nCloses
#192325\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"574af418a2dd30ad19eee0a4c49b82b41c489470"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194535","number":194535,"mergeCommit":{"message":"[Inventory]
Add Sharing button (#194535)\n\n## Summary\r\n\r\nAdds a Share link
button to the Inventory page, next to the Add Data\r\nbutton on the top
right of the screen. This creates a short link and\r\ncopies it to the
user's clipboard so they can share
it.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/42c7b2f9-da19-4ced-8d28-211234bea4cf\r\n\r\n##
How to Test\r\n\r\n- Log in and go to Inventory page. Ensure there is
data loaded and\r\nentities are showing.\r\n- Put a filter on the
inventory to restrict the results to a given\r\nstate, such as
`entity.type : \"service\"`.\r\n- Click on the `Share` button and wait
until you get a success toast\r\nmessage.\r\n- Open a new empty tab on
the browser and paste the link into the url\r\nbar to navigate to the
page.\r\n\r\n**Expected Result**: The page should navigate to the
Inventory page and\r\nload into the same state as the page on the
original browser tab.\r\n\r\nCloses
#192325\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"574af418a2dd30ad19eee0a4c49b82b41c489470"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Gonçalo Rica Pais da Silva <goncalo.rica@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:EntitiesInventory Observability entities inventory feature Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants