Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] entering [ after a source breaks the editor #191683

Closed
drewdaemon opened this issue Aug 28, 2024 · 2 comments · Fixed by #196241
Closed

[ES|QL] entering [ after a source breaks the editor #191683

drewdaemon opened this issue Aug 28, 2024 · 2 comments · Fixed by #196241
Assignees
@vadimkibana
Labels
bug Fixes for quality problems that affect the customer experience Feature:ES|QL ES|QL related features in Kibana impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana

Comments

@drewdaemon
Copy link
Contributor

drewdaemon commented Aug 28, 2024 •
edited
Loading

Kibana version:
8.15, maybe earlier

STR: Enter FROM kibana_sample_data_logs [

Screen.Recording.2024-08-28.at.4.39.01.PM.mov
@drewdaemon drewdaemon added bug Fixes for quality problems that affect the customer experience Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana labels Aug 28, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Sep 6, 2024
@drewdaemon
Copy link
Contributor Author

We've had another report of a similar issue. The reporter couldn't remember exactly what they typed, but it wasn't this.

Whoever looks into this bug should think about ways we can protect the editor from this entire class of AST construction errors.

@vadimkibana vadimkibana self-assigned this Oct 10, 2024
This was referenced Oct 15, 2024
Merged
Merged
vadimkibana added a commit that referenced this issue Oct 16, 2024
@vadimkibana
[ES|QL] Catch internal parsing errors (#196249)
1f56f21 
## Summary

Addresses this comment
#191683 (comment)

Catches parser internal errors, and reports them the same as the regular
parsing errors.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 16, 2024
@vadimkibana
[ES|QL] Catch internal parsing errors (elastic#196249)
b0ec86a 
## Summary

Addresses this comment
elastic#191683 (comment)

Catches parser internal errors, and reports them the same as the regular
parsing errors.

(cherry picked from commit 1f56f21)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 18, 2024
@vadimkibana
[ES|QL] Open bracket parsing bug (elastic#196241)
e6e8b3b 
## Summary

Closes elastic#191683

Gracefully handles open square brackets in `FROM` command.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)

(cherry picked from commit 3849d99)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 18, 2024
@vadimkibana
[ES|QL] Open bracket parsing bug (elastic#196241)
57e59f6 
## Summary

Closes elastic#191683

Gracefully handles open square brackets in `FROM` command.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)

(cherry picked from commit 3849d99)
kibanamachine added a commit that referenced this issue Oct 18, 2024
@kibanamachine @vadimkibana @stratoula
[8.x] [ES|QL] Catch internal parsing errors (#196249) (#196540)
21e0bc9 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Catch internal parsing errors
(#196249)](#196249)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Vadim
Kibana","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-16T12:04:04Z","message":"[ES|QL]
Catch internal parsing errors (#196249)\n\n## Summary\r\n\r\nAddresses
this
comment\r\nhttps://github.com//issues/191683#issuecomment-2338181503\r\n\r\nCatches
parser internal errors, and reports them the same as the
regular\r\nparsing
errors.","sha":"1f56f2102fd2108dc4469710e1a2765f918451b6","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.16.0"],"title":"[ES|QL]
Catch internal parsing
errors","number":196249,"url":"https://github.com/elastic/kibana/pull/196249","mergeCommit":{"message":"[ES|QL]
Catch internal parsing errors (#196249)\n\n## Summary\r\n\r\nAddresses
this
comment\r\nhttps://github.com//issues/191683#issuecomment-2338181503\r\n\r\nCatches
parser internal errors, and reports them the same as the
regular\r\nparsing
errors.","sha":"1f56f2102fd2108dc4469710e1a2765f918451b6"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196249","number":196249,"mergeCommit":{"message":"[ES|QL]
Catch internal parsing errors (#196249)\n\n## Summary\r\n\r\nAddresses
this
comment\r\nhttps://github.com//issues/191683#issuecomment-2338181503\r\n\r\nCatches
parser internal errors, and reports them the same as the
regular\r\nparsing
errors.","sha":"1f56f2102fd2108dc4469710e1a2765f918451b6"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Vadim Kibana <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vadimkibana vadimkibana

Labels
bug Fixes for quality problems that affect the customer experience Feature:ES|QL ES|QL related features in Kibana impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ES|QL] Open bracket parsing bug vadimkibana/kibana
4 participants
@drewdaemon @elasticmachine @stratoula @vadimkibana