Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] CSS Deprecation Issue for Team: ml-ui, Found in file: help_popover.scss #190926

Closed
Tracked by #190345 ...
petrklapka opened this issue Aug 20, 2024 · 4 comments
Closed
Tracked by #190345 ...
Assignees
Labels
good first issue low hanging fruit :ml Team:ML Team label for ML (also use :ml) v8.16.0

Comments

@petrklapka
Copy link
Member

DEPRECATION: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in & {}.

The file below has one or more instances where CSS behavior will change unless
the declaration is moved above the nested rule. Line numbers for the declaration
along with the file and line numbers in which the nested rule appears are
shown below.

More info: https://sass-lang.com/d/mixed-decls

kibana/x-pack/plugins/ml/public/application/components/help_popover/help_popover.scss

   ┌──> kibana/x-pack/plugins/ml/public/application/components/help_popover/help_popover.scss
8  │     max-height: 40vh;
   │     ^^^^^^^^^^^^^^^^ declaration
   ╵
   ┌──> kibana/node_modules/@elastic/eui/src/global_styling/mixins/_helpers.scss
55 │ ┌   &[tabindex='0']:focus:focus-visible {
56 │ │     outline-style: auto; /* 2 */
57 │ │   }
   │ └─── nested rule
   ╵

   ┌──> kibana/x-pack/plugins/ml/public/application/components/help_popover/help_popover.scss
9  │     padding: $euiSizeS;
   │     ^^^^^^^^^^^^^^^^^^ declaration
   ╵
   ┌──> kibana/node_modules/@elastic/eui/src/global_styling/mixins/_helpers.scss
55 │ ┌   &[tabindex='0']:focus:focus-visible {
56 │ │     outline-style: auto; /* 2 */
57 │ │   }
   │ └─── nested rule
   ╵
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 20, 2024
@petrklapka petrklapka added the Team:ML Team label for ML (also use :ml) label Aug 20, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 20, 2024
@peteharverson peteharverson changed the title CSS Deprecation Issue for Team: ml-ui, Found in file: help_popover.scss [ML] CSS Deprecation Issue for Team: ml-ui, Found in file: help_popover.scss Aug 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@imran-yasin
Copy link

I wanted to work on this.

@peteharverson
Copy link
Contributor

Thanks for the offer of help on this one @imran-yasin but @darnautov has just started working on this one.

@peteharverson
Copy link
Contributor

Closing, fixed by #191913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue low hanging fruit :ml Team:ML Team label for ML (also use :ml) v8.16.0
Projects
None yet
Development

No branches or pull requests

6 participants