[Fleet]: Shared integration by agent policy warning is not displayed while deleting integration from policy without any agent. #190476
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
QA:Validated
Issue has been validated by QA
Team:Fleet
Team label for Observability Data Collection Fleet team
Comments
amolnater-qasource
added
bug
|
Pinging @elastic/fleet (Team:Fleet) |
|
@karanbirsingh-qasource Please review. |
|
secondary review for this ticket is Done. |
1 task
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 3, 2024
…es actions (elastic#194808) Fixes elastic#190476 ## Summary Display missing warning when triggering delete package policies actions. Currently when no agents are enrolled this warning doesn't get displayed. - Also added unit tests for this action provider component  Video showing the warnings in different cases. The case the was fixed is the first one: https://github.com/user-attachments/assets/0fe9d1d2-c6fd-4f8c-84ad-1cce20ed7eac ### Testing - You need to have an integration policy shared between several agent policies and those agent policies shouldn't have any agents enrolled. - Go to integration policy page and try to delete the policy from "delete integration" - The warning above should appear ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 6c3ecd7)
amolnater-qasource
added
the
QA:Ready for Testing
criamico
added a commit
to criamico/kibana
that referenced
this issue
Oct 3, 2024
…es actions (elastic#194808) Fixes elastic#190476 ## Summary Display missing warning when triggering delete package policies actions. Currently when no agents are enrolled this warning doesn't get displayed. - Also added unit tests for this action provider component  Video showing the warnings in different cases. The case the was fixed is the first one: https://github.com/user-attachments/assets/0fe9d1d2-c6fd-4f8c-84ad-1cce20ed7eac ### Testing - You need to have an integration policy shared between several agent policies and those agent policies shouldn't have any agents enrolled. - Go to integration policy page and try to delete the policy from "delete integration" - The warning above should appear ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 6c3ecd7) # Conflicts: # x-pack/plugins/fleet/public/components/package_policy_delete_provider.tsx
criamico
added a commit
that referenced
this issue
Oct 4, 2024
… policies actions (#194808) (#194851) # Backport This will backport the following commits from `main` to `8.15`: - [[Fleet] Display missing warning when triggering delete package policies actions (#194808)](#194808) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cristina Amico","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-03T12:21:56Z","message":"[Fleet] Display missing warning when triggering delete package policies actions (#194808)\n\nFixes https://github.com/elastic/kibana/issues/190476\r\n\r\n## Summary\r\nDisplay missing warning when triggering delete package policies actions.\r\nCurrently when no agents are enrolled this warning doesn't get\r\ndisplayed.\r\n- Also added unit tests for this action provider component\r\n\r\n\r\n\r\nVideo showing the warnings in different cases. The case the was fixed is\r\nthe first one:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/0fe9d1d2-c6fd-4f8c-84ad-1cce20ed7eac\r\n\r\n\r\n### Testing\r\n\r\n- You need to have an integration policy shared between several agent\r\npolicies and those agent policies shouldn't have any agents enrolled.\r\n- Go to integration policy page and try to delete the policy from\r\n\"delete integration\"\r\n- The warning above should appear\r\n\r\n\r\n### Checklist\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"6c3ecd7fbaccb6d3d60495cbbaf0dabd19c7db9a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-major","v8.16.0"],"number":194808,"url":"https://github.com/elastic/kibana/pull/194808","mergeCommit":{"message":"[Fleet] Display missing warning when triggering delete package policies actions (#194808)\n\nFixes https://github.com/elastic/kibana/issues/190476\r\n\r\n## Summary\r\nDisplay missing warning when triggering delete package policies actions.\r\nCurrently when no agents are enrolled this warning doesn't get\r\ndisplayed.\r\n- Also added unit tests for this action provider component\r\n\r\n\r\n\r\nVideo showing the warnings in different cases. The case the was fixed is\r\nthe first one:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/0fe9d1d2-c6fd-4f8c-84ad-1cce20ed7eac\r\n\r\n\r\n### Testing\r\n\r\n- You need to have an integration policy shared between several agent\r\npolicies and those agent policies shouldn't have any agents enrolled.\r\n- Go to integration policy page and try to delete the policy from\r\n\"delete integration\"\r\n- The warning above should appear\r\n\r\n\r\n### Checklist\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"6c3ecd7fbaccb6d3d60495cbbaf0dabd19c7db9a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194808","number":194808,"mergeCommit":{"message":"[Fleet] Display missing warning when triggering delete package policies actions (#194808)\n\nFixes https://github.com/elastic/kibana/issues/190476\r\n\r\n## Summary\r\nDisplay missing warning when triggering delete package policies actions.\r\nCurrently when no agents are enrolled this warning doesn't get\r\ndisplayed.\r\n- Also added unit tests for this action provider component\r\n\r\n\r\n\r\nVideo showing the warnings in different cases. The case the was fixed is\r\nthe first one:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/0fe9d1d2-c6fd-4f8c-84ad-1cce20ed7eac\r\n\r\n\r\n### Testing\r\n\r\n- You need to have an integration policy shared between several agent\r\npolicies and those agent policies shouldn't have any agents enrolled.\r\n- Go to integration policy page and try to delete the policy from\r\n\"delete integration\"\r\n- The warning above should appear\r\n\r\n\r\n### Checklist\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"6c3ecd7fbaccb6d3d60495cbbaf0dabd19c7db9a"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/194828","number":194828,"state":"MERGED","mergeCommit":{"sha":"8347dedf0fe622e513eeb67dbaddc3cd0dd6d2cf","message":"[8.x] [Fleet] Display missing warning when triggering delete package policies actions (#194808) (#194828)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Fleet] Display missing warning when triggering delete package\npolicies actions\n(#194808)](https://github.com/elastic/kibana/pull/194808)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Cristina\nAmico\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-03T12:21:56Z\",\"message\":\"[Fleet]\nDisplay missing warning when triggering delete package policies actions\n(#194808)\\n\\nFixes\nhttps://github.com//issues/190476\\r\\n\\r\\n##\nSummary\\r\\nDisplay missing warning when triggering delete package\npolicies actions.\\r\\nCurrently when no agents are enrolled this warning\ndoesn't get\\r\\ndisplayed.\\r\\n- Also added unit tests for this action\nprovider component\\r\\n\\r\\n\\r\\n\\r\\nVideo\nshowing the warnings in different cases. The case the was fixed\nis\\r\\nthe first\none:\\r\\n\\r\\n\\r\\nhttps://github.com/user-attachments/assets/0fe9d1d2-c6fd-4f8c-84ad-1cce20ed7eac\\r\\n\\r\\n\\r\\n###\nTesting\\r\\n\\r\\n- You need to have an integration policy shared between\nseveral agent\\r\\npolicies and those agent policies shouldn't have any\nagents enrolled.\\r\\n- Go to integration policy page and try to delete\nthe policy from\\r\\n\\\"delete integration\\\"\\r\\n- The warning above should\nappear\\r\\n\\r\\n\\r\\n### Checklist\\r\\n- [ ] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"6c3ecd7fbaccb6d3d60495cbbaf0dabd19c7db9a\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.16.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"Team:Fleet\",\"v9.0.0\",\"backport:prev-major\"],\"title\":\"[Fleet]\nDisplay missing warning when triggering delete package policies\nactions\",\"number\":194808,\"url\":\"https://github.com/elastic/kibana/pull/194808\",\"mergeCommit\":{\"message\":\"[Fleet]\nDisplay missing warning when triggering delete package policies actions\n(#194808)\\n\\nFixes\nhttps://github.com//issues/190476\\r\\n\\r\\n##\nSummary\\r\\nDisplay missing warning when triggering delete package\npolicies actions.\\r\\nCurrently when no agents are enrolled this warning\ndoesn't get\\r\\ndisplayed.\\r\\n- Also added unit tests for this action\nprovider component\\r\\n\\r\\n\\r\\n\\r\\nVideo\nshowing the warnings in different cases. The case the was fixed\nis\\r\\nthe first\none:\\r\\n\\r\\n\\r\\nhttps://github.com/user-attachments/assets/0fe9d1d2-c6fd-4f8c-84ad-1cce20ed7eac\\r\\n\\r\\n\\r\\n###\nTesting\\r\\n\\r\\n- You need to have an integration policy shared between\nseveral agent\\r\\npolicies and those agent policies shouldn't have any\nagents enrolled.\\r\\n- Go to integration policy page and try to delete\nthe policy from\\r\\n\\\"delete integration\\\"\\r\\n- The warning above should\nappear\\r\\n\\r\\n\\r\\n### Checklist\\r\\n- [ ] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"6c3ecd7fbaccb6d3d60495cbbaf0dabd19c7db9a\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/194808\",\"number\":194808,\"mergeCommit\":{\"message\":\"[Fleet]\nDisplay missing warning when triggering delete package policies actions\n(#194808)\\n\\nFixes\nhttps://github.com//issues/190476\\r\\n\\r\\n##\nSummary\\r\\nDisplay missing warning when triggering delete package\npolicies actions.\\r\\nCurrently when no agents are enrolled this warning\ndoesn't get\\r\\ndisplayed.\\r\\n- Also added unit tests for this action\nprovider component\\r\\n\\r\\n\\r\\n\\r\\nVideo\nshowing the warnings in different cases. The case the was fixed\nis\\r\\nthe first\none:\\r\\n\\r\\n\\r\\nhttps://github.com/user-attachments/assets/0fe9d1d2-c6fd-4f8c-84ad-1cce20ed7eac\\r\\n\\r\\n\\r\\n###\nTesting\\r\\n\\r\\n- You need to have an integration policy shared between\nseveral agent\\r\\npolicies and those agent policies shouldn't have any\nagents enrolled.\\r\\n- Go to integration policy page and try to delete\nthe policy from\\r\\n\\\"delete integration\\\"\\r\\n- The warning above should\nappear\\r\\n\\r\\n\\r\\n### Checklist\\r\\n- [ ] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"6c3ecd7fbaccb6d3d60495cbbaf0dabd19c7db9a\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Cristina Amico <[email protected]>"}}]}] BACKPORT--> --------- Co-authored-by: Elastic Machine <[email protected]>
|
Hi Team, We have revalidated this issue on latest 8.16.0 SNAPSHOT and found it fixed now. Observations:
Build details: Screen Recording Nginx.-.Integrations.-.Elastic.-.Google.Chrome.2024-10-07.14-08-07.mp4Hence, we are marking this issue as QA:Validated. Thanks!! |
amolnater-qasource
added
QA:Validated
tiansivive
pushed a commit
to tiansivive/kibana
that referenced
this issue
Oct 7, 2024
…es actions (elastic#194808) Fixes elastic#190476 ## Summary Display missing warning when triggering delete package policies actions. Currently when no agents are enrolled this warning doesn't get displayed. - Also added unit tests for this action provider component  Video showing the warnings in different cases. The case the was fixed is the first one: https://github.com/user-attachments/assets/0fe9d1d2-c6fd-4f8c-84ad-1cce20ed7eac ### Testing - You need to have an integration policy shared between several agent policies and those agent policies shouldn't have any agents enrolled. - Go to integration policy page and try to delete the policy from "delete integration" - The warning above should appear ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kibana Build details:
Preconditions:
Steps to reproduce:
Expected Result:
Shared integration by agent policy warning should be displayed while deleting integration from policy without any agent.
Screen Recording:
Nginx.-.Integrations.-.Elastic.-.Google.Chrome.2024-08-14.12-48-49.mp4
Feature:
#75867
The text was updated successfully, but these errors were encountered: