Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddable Rebuild] Unsaved changes stuck on Dashboard after adding a React embeddable #190066

Closed
Heenawter opened this issue Aug 7, 2024 · 1 comment · Fixed by #190165
Closed

[Embeddable Rebuild] Unsaved changes stuck on Dashboard after adding a React embeddable #190066

Heenawter opened this issue Aug 7, 2024 · 1 comment · Fixed by #190165
Assignees
@Heenawter
Labels
bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

Describe the bug:
Adding any React embeddable to the dashboard results in unsaved changes that do not go away until either "Reset" is clicked or the dashboard is reloaded. Possibly caused by the same underlying issue as #190065, but creating a separate issue just in case they are unrelated.

Steps to reproduce:

  1. Add any React embeddable to the dashboard via the "Add panel" menu (Maps, Links, Image, etc.)
  2. Try to save your dashboard
  3. Unsaved changes do not get cleared 🔥

Expected behavior:
Unsaved changes should go away.

Screenshots (if relevant):

Screen.Recording.2024-08-07.at.8.32.26.AM.mov
@Heenawter Heenawter added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. project:embeddableRebuild labels Aug 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Zacqary Zacqary mentioned this issue Aug 7, 2024
Merged
1 task
@Heenawter Heenawter mentioned this issue Aug 7, 2024
Merged
@Heenawter Heenawter self-assigned this Aug 8, 2024
This was referenced Aug 8, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Heenawter Heenawter

Labels
bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Embeddable Rebuild] Fix stuck unsaved changes Heenawter/kibana
2 participants
@Heenawter @elasticmachine