Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddable Rebuild] Unsaved changes stuck after navigating to an editor and back to Dashboard #190065

Closed
Heenawter opened this issue Aug 7, 2024 · 2 comments
Closed

[Embeddable Rebuild] Unsaved changes stuck after navigating to an editor and back to Dashboard #190065

Heenawter opened this issue Aug 7, 2024 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

Describe the bug:
After editing a visualization that uses the state transfer service to navigate to an editor + back to dashboard, unsaved changes gets stuck on the Dashboard. Possibly related to #188039, since we changed some logic for handling the incomingEmbeddable in that PR.

Steps to reproduce:

  1. Add a map to a dashboard (or any other embeddable that does not have inline editing + uses the state transfer service)
  2. Save the dashboard
  3. Edit the embeddable from step 1
  4. Make some changes, then click "Save and return"
  5. Your dashboard has unsaved changes - this is expected
  6. Try to save your dashboard - unsaved changes does not go away 🔥

Expected behavior:
Unsaved changes should go away.

Screenshots (if relevant):

Screen.Recording.2024-08-07.at.8.25.38.AM.mov
@Heenawter Heenawter added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. project:embeddableRebuild labels Aug 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter mentioned this issue Aug 7, 2024
Closed
@Heenawter
Copy link
Contributor Author

Closing - tested and it is indeed the same underlying issue as #190066

@Heenawter Heenawter closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Heenawter @elasticmachine