Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OneDiscover][DocViewer] Remember the last active tab #188717

Closed
kertal opened this issue Jul 19, 2024 · 1 comment · Fixed by #189806
Closed

[OneDiscover][DocViewer] Remember the last active tab #188717

kertal opened this issue Jul 19, 2024 · 1 comment · Fixed by #189806
Assignees
@jughosta
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Feature:UnifiedDocViewer Issues relating to the unified doc viewer component impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Jul 19, 2024

Describe the feature:

When expanding a document in Discover, the DocViewer should remember the last selected tab. We recently added the log overview tab in #187096, and the contextual awareness allows profiles to add more tabs. It would improve the UX of the Docviewer, when the last active tab would be remembered. Given, that the remembered tab is not available in a different profile, the first tab should be displayed instead.

Describe a specific use case for the feature:
A profile has a Log overview tab, but that doesn't contain much interesting informantion, so users prefer the Table tab.
Currently every time a document/row is expanded, users have to re-select the table tab.
Discover_-_Elastic
@kertal kertal added Feature:Discover Discover Application enhancement New value added to drive a business result Feature:UnifiedDocViewer Issues relating to the unified doc viewer component Project:OneDiscover Enrich Discover with contextual awareness labels Jul 19, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 19, 2024
@kertal kertal added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Jul 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 19, 2024
@kertal kertal added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Jul 19, 2024
@jughosta jughosta mentioned this issue Aug 2, 2024
Merged
1 task
jughosta added a commit that referenced this issue Aug 4, 2024
@jughosta
[OneDiscover][DocViewer] Remember the last active tab (#189806)
36d0ae7 
- Closes #188717

## Summary

With this PR the last active DocViewer tab is going to be stored in
local storage under `unifiedDocViewer:initialTab` and restored when
opening the flyout next time.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Feature:UnifiedDocViewer Issues relating to the unified doc viewer component impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[OneDiscover][DocViewer] Remember the last active tab jughosta/kibana
3 participants
@kertal @jughosta @elasticmachine