[Discover] Improve saved search embeddable #188550
Labels
enhancement
New value added to drive a business result
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
loe:needs-research
This issue requires some research before it can be worked on or estimated
Team:DataDiscovery
Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Comments
jughosta
added
enhancement
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
4 tasks
kertal
added
impact:medium
10 tasks
davismcphee
added a commit
that referenced
this issue
Aug 20, 2024
#190288) ## Summary This PR improves the handling of columns with absolute widths in Discover, including the following enhancements: - If there are no auto width columns in the profile default app state, set the last column to auto width so the default columns always fill the grid. - If there are no auto width columns remaining when removing a column from the grid, set the last column to auto width so the remaining columns fill the grid. - Add a "Reset width" button to the column header popovers to allow resetting absolute width columns back to auto width. https://github.com/user-attachments/assets/0c588969-5720-40e3-91e2-07a83a93b797 Resolves #189817. Related #188550. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Julia Rechkunova <[email protected]>
|
@jughosta Just checking if you think we should still leave this issue open or close it? The sub issues are all resolved or closed now, and I think @elastic/kibana-presentation are actively working on improving page load bundles related to embeddable framework code. Maybe we should close this one and just spin off a separate dedicated issue for the time range? |
|
@davismcphee I think we can close. Dashboard did not use the time range from saved search before and I don't see why would it be necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@kbn/presentation-containersimports [Embeddable Rebuild] [Saved Search] Migrate saved search embeddable to new embeddable framework #180536 (review)The text was updated successfully, but these errors were encountered: