[ResponseOps][Cases] Create case using templates - Design Review #188187
Assignees
Labels
appex-ro-mx-team-member-onboarding
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
Comments
joana-cps
added
the
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
adcoelho
added a commit
that referenced
this issue
Sep 12, 2024
Connected to #188187 ## Summary - Changed the cases `Settings` button and icon - Changed the the `Additional fields` title to `Custom fields` for consistency <img width="1728" alt="Screenshot 2024-09-09 at 20 15 39" src="https://github.com/user-attachments/assets/1fb1232a-f958-4d4d-8694-f85cc8872237"> <img width="1443" alt="Screenshot 2024-09-09 at 20 34 27" src="https://github.com/user-attachments/assets/0fbdae02-65a6-4128-adc7-39f51cc2d5e6"> <img width="1370" alt="Screenshot 2024-09-09 at 20 34 57" src="https://github.com/user-attachments/assets/c216407a-ac13-4579-8007-531c79d52de7">
heespi
added
appex-ro-mx-team-member-onboarding
and removed
Team:ResponseOps
cnasikas
added
Team:ResponseOps
georgianaonoleata1904
added a commit
that referenced
this issue
Oct 2, 2024
Connected to #188187 ## Summary - Field names have been aligned on top to ensure consistency with the fields area on the right <img width="1495" alt="Screenshot 2024-10-01 at 14 30 38" src="https://github.com/user-attachments/assets/51578be1-6cd8-43e0-a800-61e562aa5d77"> - Custom field and template name text size has been reduced to align with the badge  --------- Co-authored-by: kibanamachine <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 2, 2024
Connected to elastic#188187 ## Summary - Field names have been aligned on top to ensure consistency with the fields area on the right <img width="1495" alt="Screenshot 2024-10-01 at 14 30 38" src="https://github.com/user-attachments/assets/51578be1-6cd8-43e0-a800-61e562aa5d77"> - Custom field and template name text size has been reduced to align with the badge  --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 616c6e8)
georgianaonoleata1904
added a commit
that referenced
this issue
Oct 7, 2024
## Summary Connects to #188187 - the "add template" button is now hidden once the user reaches the limit of 10 templates and the message is displayed in a subdued color to inform the user that the limit has been reached.  - same applies to custom fields 
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 7, 2024
## Summary Connects to elastic#188187 - the "add template" button is now hidden once the user reaches the limit of 10 templates and the message is displayed in a subdued color to inform the user that the limit has been reached.  - same applies to custom fields  (cherry picked from commit d5e2afd)
kibanamachine
added a commit
that referenced
this issue
Oct 7, 2024
) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Cases] Design Review changes PR 2 (#194681)](#194681) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Georgiana-Andreea Onoleață","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-07T09:47:40Z","message":"[ResponseOps][Cases] Design Review changes PR 2 (#194681)\n\n## Summary\r\n\r\nConnects to #188187 \r\n\r\n- the \"add template\" button is now hidden once the user reaches the\r\nlimit of 10 templates and the message is displayed in a subdued color to\r\ninform the user that the limit has been reached.\r\n\r\n\r\n\r\n- same applies to custom fields\r\n\r\n","sha":"d5e2afdeee9a48d2da763fc6e300723cb855b953","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Feature:Cases","backport:prev-minor","v8.16.0"],"title":"[ResponseOps][Cases] Design Review changes PR 2","number":194681,"url":"https://github.com/elastic/kibana/pull/194681","mergeCommit":{"message":"[ResponseOps][Cases] Design Review changes PR 2 (#194681)\n\n## Summary\r\n\r\nConnects to #188187 \r\n\r\n- the \"add template\" button is now hidden once the user reaches the\r\nlimit of 10 templates and the message is displayed in a subdued color to\r\ninform the user that the limit has been reached.\r\n\r\n\r\n\r\n- same applies to custom fields\r\n\r\n","sha":"d5e2afdeee9a48d2da763fc6e300723cb855b953"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194681","number":194681,"mergeCommit":{"message":"[ResponseOps][Cases] Design Review changes PR 2 (#194681)\n\n## Summary\r\n\r\nConnects to #188187 \r\n\r\n- the \"add template\" button is now hidden once the user reaches the\r\nlimit of 10 templates and the message is displayed in a subdued color to\r\ninform the user that the limit has been reached.\r\n\r\n\r\n\r\n- same applies to custom fields\r\n\r\n","sha":"d5e2afdeee9a48d2da763fc6e300723cb855b953"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Georgiana-Andreea Onoleață <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 8, 2024
## Summary Closes elastic#188187 - The fly out title now updates appropriately when editing an existing field or template, displaying "Edit field" and "Edit template" respectively. https://github.com/user-attachments/assets/b85d7d27-ba89-4fbd-97c4-dc5873dda6d8 (cherry picked from commit c6dd76e)
kibanamachine
added a commit
that referenced
this issue
Oct 8, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Cases]Design Review changes PR 3 (#194936)](#194936) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Georgiana-Andreea Onoleață","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-08T13:10:24Z","message":"[ResponseOps][Cases]Design Review changes PR 3 (#194936)\n\n## Summary\r\n\r\nCloses #188187 \r\n\r\n- The fly out title now updates appropriately when editing an existing\r\nfield or template, displaying \"Edit field\" and \"Edit template\"\r\nrespectively.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/b85d7d27-ba89-4fbd-97c4-dc5873dda6d8","sha":"c6dd76e76c4bad4c6f0a78dda86b0cc67eb31ca8","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Feature:Cases","backport:prev-minor","v8.16.0"],"title":"[ResponseOps][Cases]Design Review changes PR 3","number":194936,"url":"https://github.com/elastic/kibana/pull/194936","mergeCommit":{"message":"[ResponseOps][Cases]Design Review changes PR 3 (#194936)\n\n## Summary\r\n\r\nCloses #188187 \r\n\r\n- The fly out title now updates appropriately when editing an existing\r\nfield or template, displaying \"Edit field\" and \"Edit template\"\r\nrespectively.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/b85d7d27-ba89-4fbd-97c4-dc5873dda6d8","sha":"c6dd76e76c4bad4c6f0a78dda86b0cc67eb31ca8"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194936","number":194936,"mergeCommit":{"message":"[ResponseOps][Cases]Design Review changes PR 3 (#194936)\n\n## Summary\r\n\r\nCloses #188187 \r\n\r\n- The fly out title now updates appropriately when editing an existing\r\nfield or template, displaying \"Edit field\" and \"Edit template\"\r\nrespectively.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/b85d7d27-ba89-4fbd-97c4-dc5873dda6d8","sha":"c6dd76e76c4bad4c6f0a78dda86b0cc67eb31ca8"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Georgiana-Andreea Onoleață <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Design Review
For consistency, the settings button should look like the settings button on the Rules page. ([ResponseOps][Connectors] Move create connector button in Management #190125, [ResponseOps][Cases] Design Review changes #1 #192356)
Field names should be aligned on top, to be in line with the fields area on the right. ([ResponseOps][Cases] Design Review changes PR 1 #194560)
Field and template name text size should be smaller (will align with the badge) ([ResponseOps][Cases] Design Review changes PR 1 #194560)
Instead of leaving the button and allowing the user to click to then trigger an error message, let's just hide the button and show the message in subdued text color informing the user that he has reached the limit of 10. ([ResponseOps][Cases] Design Review changes PR 2 #194681)
Form
When we edit an existing field or an existing template the flyout title should change to "Edit field" and "Edit template" respectively. ([ResponseOps][Cases]Design Review changes PR 3 #194936)
The text was updated successfully, but these errors were encountered: