Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Trained Models page does not respond well to autoscaling #188035

Closed
maxhniebergall opened this issue Jul 10, 2024 · 1 comment · Fixed by #188847
Closed

[ML] Trained Models page does not respond well to autoscaling #188035

maxhniebergall opened this issue Jul 10, 2024 · 1 comment · Fixed by #188847
Assignees
@darnautov
Labels
bug Fixes for quality problems that affect the customer experience Feature:3rd Party Models ML 3rd party models :ml v8.15.0

Comments

@maxhniebergall
Copy link
Member

Kibana version:
8.16-SNAPSHOT

Original install method (e.g. download page, yum, from source, etc.):
qaf cloud-deploy
Describe the bug:
when no ML nodes are present in the cluster, the model State says "ready to deploy" and the model stats are empty, which is confusing. We should add an additional state for "autoscaling" or something

Steps to reproduce:

  1. create cloud cluster with zero ML nodes with autoscaling enabled
  2. install elser
  3. deploy elser
  4. confusion

Expected behavior:
the trained models page mentions that autoscaling is happening
@maxhniebergall maxhniebergall added bug Fixes for quality problems that affect the customer experience :ml Feature:3rd Party Models ML 3rd party models labels Jul 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov mentioned this issue Jul 22, 2024
Merged
1 task
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jul 23, 2024
@darnautov
[ML] Fixes display of model state in trained models list with startin…
26aba54 
…g and stopping deployments (elastic#188847)

## Summary

Fixes elastic#188035 and elastic#181093

<img width="1434" alt="image"
src="https://github.com/user-attachments/assets/6c14afa3-2908-45ff-a68d-88ee18f18964">

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 9669bfd)
kibanamachine added a commit that referenced this issue Jul 23, 2024
@kibanamachine @darnautov
[8.15] [ML] Fixes display of model state in trained models list with …
bc1aca3 
…starting and stopping deployments (#188847) (#188928)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[ML] Fixes display of model state in trained models list with
starting and stopping deployments
(#188847)](#188847)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-23T12:18:49Z","message":"[ML]
Fixes display of model state in trained models list with starting and
stopping deployments (#188847)\n\n## Summary\r\n\r\nFixes #188035 and
#181093\r\n\r\n<img width=\"1434\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/6c14afa3-2908-45ff-a68d-88ee18f18964\">\r\n\r\n\r\n\r\n###
Checklist\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"9669bfde47b70dc925a39aac39ab8a1b6c3dae3b","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:3rd
Party Models","Team:ML","v8.15.0","v8.16.0"],"title":"[ML] Fixes display
of model state in trained models list with starting and stopping
deployments
","number":188847,"url":"https://github.com/elastic/kibana/pull/188847","mergeCommit":{"message":"[ML]
Fixes display of model state in trained models list with starting and
stopping deployments (#188847)\n\n## Summary\r\n\r\nFixes #188035 and
#181093\r\n\r\n<img width=\"1434\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/6c14afa3-2908-45ff-a68d-88ee18f18964\">\r\n\r\n\r\n\r\n###
Checklist\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"9669bfde47b70dc925a39aac39ab8a1b6c3dae3b"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188847","number":188847,"mergeCommit":{"message":"[ML]
Fixes display of model state in trained models list with starting and
stopping deployments (#188847)\n\n## Summary\r\n\r\nFixes #188035 and
#181093\r\n\r\n<img width=\"1434\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/6c14afa3-2908-45ff-a68d-88ee18f18964\">\r\n\r\n\r\n\r\n###
Checklist\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"9669bfde47b70dc925a39aac39ab8a1b6c3dae3b"}}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darnautov darnautov

Labels
bug Fixes for quality problems that affect the customer experience Feature:3rd Party Models ML 3rd party models :ml v8.15.0
Projects
None yet
Milestone
No milestone
4 participants
@darnautov @peteharverson @elasticmachine @maxhniebergall