Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[embeddable rebuild] remove legacy embeddable system #186119

Closed
12 tasks
nreese opened this issue Jun 12, 2024 · 3 comments
Closed
12 tasks

[embeddable rebuild] remove legacy embeddable system #186119

nreese opened this issue Jun 12, 2024 · 3 comments
Labels
Meta project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nreese
Copy link
Contributor

nreese commented Jun 12, 2024

  • Remove embeddable.registerEmbeddableFactory, preventing legacy embeddable registration - small
  • Update dashboard "Add from library" to remove usage of legacy embeddables - small
  • Update dashboard "Add panel" to remove usage of legacy embeddables - small
  • Update Canvas "Add from library" to remove usage of legacy embeddables - small
  • Update Canvas "Add panel" to remove usage of legacy embeddables - small
  • Remove usage of getEmbeddableFactory in DashboardContainer.addNewPanel - small
  • Remove usage of getEmbeddableFactory in DashboardRenderer - small
  • Remove usage of getEmbeddableFactory in migrateDashboardInput - medium. Question: how will migrations be run for legacy panels replaced by new react embeddable panels?
  • Remove legacy embeddable registry and getter methods - small
  • Refactor DashboardContainer so that it no longer implements Container interface - large
  • Remove Container interface - small
  • Remove Embeddable interface and all associated types like EmbeddableInput and EmbeddableOutput - large since there may be unexpected usages of these classes throughout Kibana.
@nreese nreese added Meta Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas project:embeddableRebuild labels Jun 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor

Hey @nreese should we maybe put this list in #180058 instead of creating a new issue?

@nreese
Copy link
Contributor Author

nreese commented Jun 12, 2024

Closing, moved task list to existing cleanup issue #180058

@nreese nreese closed this as completed Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

3 participants