Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embeddables Rebuild] Delete Legacy Embeddable Framework #180058

Open
12 tasks
Tracked by #167429
ThomThomson opened this issue Apr 4, 2024 · 0 comments
Open
12 tasks
Tracked by #167429

[Embeddables Rebuild] Delete Legacy Embeddable Framework #180058

ThomThomson opened this issue Apr 4, 2024 · 0 comments
Assignees
Labels
blocked Feature:Embeddables Relating to the Embeddable system impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

ThomThomson commented Apr 4, 2024

Problem

blocked on #180059

Once all usages of the legacy Embeddable framework are converted to the new framework, including Dashboard, we will need to remove the legacy embeddable framework entirely, including all examples and unit tests.

Note: This must not include the serverside embeddable migrations, as these might still be needed when upgrading a cluster from a version before the clientside migrations were introduced (~8.13).

Tasks

  • Remove embeddable.registerEmbeddableFactory, preventing legacy embeddable registration - small
  • Update dashboard "Add from library" to remove usage of legacy embeddables - small
  • Update dashboard "Add panel" to remove usage of legacy embeddables - small
  • Update Canvas "Add from library" to remove usage of legacy embeddables - small
  • Update Canvas "Add panel" to remove usage of legacy embeddables - small
  • Remove usage of getEmbeddableFactory in DashboardContainer.addNewPanel - small
  • Remove usage of getEmbeddableFactory in DashboardRenderer - small
  • Remove usage of getEmbeddableFactory in migrateDashboardInput - medium. Question: how will migrations be run for legacy panels replaced by new react embeddable panels?
  • Remove legacy embeddable registry and getter methods - small
  • Refactor DashboardContainer so that it no longer implements Container interface - [Embeddables Rebuild] Migrate Dashboard embeddable to plain javascript object #197281
  • Remove Container interface - small
  • Remove Embeddable interface and all associated types like EmbeddableInput and EmbeddableOutput - large since there may be unexpected usages of these classes throughout Kibana.
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 4, 2024
@ThomThomson ThomThomson added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Feature:Embeddables Relating to the Embeddable system labels Apr 4, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 4, 2024
@ThomThomson ThomThomson changed the title Delete Legacy Embeddable Framework [Embeddables Rebuild] Delete Legacy Embeddable Framework Apr 4, 2024
@nreese nreese self-assigned this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Feature:Embeddables Relating to the Embeddable system impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

2 participants