Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] For ES|QL searches, changing the current tab then reverting unsaved changes causes subsequent tab changes not to trigger the badge #184624

Closed
davismcphee opened this issue Jun 3, 2024 · 1 comment · Fixed by #187244
Closed

[Discover] For ES|QL searches, changing the current tab then reverting unsaved changes causes subsequent tab changes not to trigger the badge #184624

davismcphee opened this issue Jun 3, 2024 · 1 comment · Fixed by #187244
Assignees
@jughosta
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@davismcphee
Copy link
Contributor

After opening an ES|QL search and changing the current tab, the unsaved changes badge is triggered as expected. But if the unsaved changes are then reverted, subsequent tab changes do not trigger the unsaved changes badge until refreshing the page:

tabs.mp4
@davismcphee davismcphee added bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:ES|QL ES|QL related features in Kibana labels Jun 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee davismcphee mentioned this issue Jun 3, 2024
Merged
10 tasks
@jughosta jughosta mentioned this issue Jul 1, 2024
Merged
1 task
@jughosta jughosta self-assigned this Jul 1, 2024
jughosta added a commit that referenced this issue Jul 5, 2024
@jughosta @kertal
[Discover] View mode changes should trigger Unsaved changes badge in …
25d7346 
…ES|QL (#187244)

- Closes #184624

## Summary

This PR updates the logic to show Unsaved changes badge when view mode
changes in ES|QL mode.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Matthias Wilhelm <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jul 5, 2024
@jughosta
[Discover] View mode changes should trigger Unsaved changes badge in …
bce9018 
…ES|QL (elastic#187244)

- Closes elastic#184624

## Summary

This PR updates the logic to show Unsaved changes badge when view mode
changes in ES|QL mode.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Matthias Wilhelm <[email protected]>
(cherry picked from commit 25d7346)
kibanamachine referenced this issue Jul 9, 2024
@kibanamachine @jughosta
[8.15] [Discover] View mode changes should trigger Unsaved changes ba…
9c5f961 
…dge in ES|QL (#187244) (#187687)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Discover] View mode changes should trigger Unsaved changes badge in
ES|QL (#187244)](#187244)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-05T14:46:00Z","message":"[Discover]
View mode changes should trigger Unsaved changes badge in ES|QL
(#187244)\n\n- Closes
https://github.com/elastic/kibana/issues/184624\r\n\r\n##
Summary\r\n\r\nThis PR updates the logic to show Unsaved changes badge
when view mode\r\nchanges in ES|QL mode.\r\n\r\n### Checklist\r\n\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Matthias Wilhelm
<[email protected]>","sha":"25d73466c3e1afff0c17b7f8800f92449e9480a8","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.16.0"],"title":"[Discover]
View mode changes should trigger Unsaved changes badge in
ES|QL","number":187244,"url":"https://github.com/elastic/kibana/pull/187244","mergeCommit":{"message":"[Discover]
View mode changes should trigger Unsaved changes badge in ES|QL
(#187244)\n\n- Closes
https://github.com/elastic/kibana/issues/184624\r\n\r\n##
Summary\r\n\r\nThis PR updates the logic to show Unsaved changes badge
when view mode\r\nchanges in ES|QL mode.\r\n\r\n### Checklist\r\n\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Matthias Wilhelm
<[email protected]>","sha":"25d73466c3e1afff0c17b7f8800f92449e9480a8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187244","number":187244,"mergeCommit":{"message":"[Discover]
View mode changes should trigger Unsaved changes badge in ES|QL
(#187244)\n\n- Closes
https://github.com/elastic/kibana/issues/184624\r\n\r\n##
Summary\r\n\r\nThis PR updates the logic to show Unsaved changes badge
when view mode\r\nchanges in ES|QL mode.\r\n\r\n### Checklist\r\n\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Matthias Wilhelm
<[email protected]>","sha":"25d73466c3e1afff0c17b7f8800f92449e9480a8"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] View mode changes should trigger Unsaved changes badge in ES|QL jughosta/kibana
3 participants
@jughosta @elasticmachine @davismcphee