Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Unskip maintenance window callout Cypress tests skipped because of a bug in serverless roles #184160

Open
Tracked by #187301
MadameSheema opened this issue May 23, 2024 · 3 comments
Assignees
Labels
Feature:Rule Management Security Solution Detection Rule Management area skipped-test Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@MadameSheema
Copy link
Member

MadameSheema commented May 23, 2024

Caused by: #184151

Summary

The test x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/maintenance_windows/maintenance_window_callout.cy.ts has been skipped from serverless executions due to the following issue: #184151

@MadameSheema MadameSheema added skipped-test Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team labels May 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@banderror banderror self-assigned this May 24, 2024
@banderror banderror added Feature:Rule Management Security Solution Detection Rule Management area 8.15 candidate and removed triage_needed labels May 24, 2024
@banderror banderror assigned nikitaindik and unassigned banderror May 24, 2024
@banderror banderror changed the title Skipped test: x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/maintenance_windows/maintenance_window_callout.cy.ts - [Security Solution] Unskip maintenance window callout Cypress tests skipped because of a bug in serverless roles May 24, 2024
MadameSheema added a commit that referenced this issue Jun 3, 2024
… platform_engineer (#183608)

## Summary

Addresses: #184140

In this PR we are addressing the short-term solution of
#184135 where we are moving from
using for serverless `admin` role for MKI environments and
`system_indices_superuser` for stateless environments to
`platform_engineer`.

To make the above change happen, some adjustments have been introduced
to make the tests work:

### Rename of custom indexes

The `admin` or `system_indices_superuser` has access to any index on the
system, but built-in roles in security serverless projects just have
access to some or all the security default indexes, so they cannot
access custom indexes.

To make the tests work with the `platform_engineer` all the custom
indexes that we use for testing purposes have been renamed to match
ours.

### `waitForTheRuleToBeExecuted` removed from some tests

`waitForTheRuleToBeExecuted` waits for the rule status to be `succeeded`
but the `platform_engineer` does not have access to all the indexes, so
instead the final status result will be `warning` so this method will
timeout.

Originally that method was created in order to make sure that some
alerts are going to be displayed but, after it, we are calling
`waitForAlertsToPopulate` that makes sure that we have alerts.

### Some tests have been skipped from serverless executions
- Entity analytics tests exercising the legacy risk score have been
removed from serverless executions, since it is not used on serverless
projects.
- Maintenance window callout test has been skipped in serverless due to
the following reason: #184160
- One of the users tabs test has been skipped as well due to the
following reason: #184201

---------

Co-authored-by: Devin Hurley <[email protected]>
Co-authored-by: Georgii Gorbachev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Rule Management Security Solution Detection Rule Management area skipped-test Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

No branches or pull requests

4 participants